Sign upLogin

APTrust/dart

View on GitHub
Star
ui/controllers/bagit_profile_controller.js

Summary

Maintainability
B
4 hrs
Test Coverage

File bagit_profile_controller.js has 312 lines of code (exceeds 250 allowed). Consider refactoring.
Invalid

const $ = require('jquery');
const { Context } = require('../../core/context');
const { BagItProfile } = require('../../bagit/bagit_profile');
const { BagItProfileForm } = require('../forms/bagit_profile_form');
const { BagItUtil } = require('../../bagit/bagit_util');
Severity: Minor
Found in ui/controllers/bagit_profile_controller.js - About 3 hrs to fix

    BagItProfileController has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class BagItProfileController extends BaseController {

    constructor(params) {
        super(params, 'Settings');
        /**
    Severity: Minor
    Found in ui/controllers/bagit_profile_controller.js - About 2 hrs to fix

      Function _importProfileObject has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _importProfileObject(json, profileUrl) {
        let obj;
        try {
            obj = JSON.parse(json);
        } catch (ex) {
      Severity: Minor
      Found in ui/controllers/bagit_profile_controller.js - About 1 hr to fix

        Function _getPageLevelErrors has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            _getPageLevelErrors(profile) {
        let errors = [];
        if (!Util.isEmpty(profile.errors["name"])) {
            errors.push(Context.y18n.__("About Tab: %s", profile.errors["name"]));
        }
        Severity: Minor
        Found in ui/controllers/bagit_profile_controller.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _importProfileObject has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            _importProfileObject(json, profileUrl) {
        let obj;
        try {
            obj = JSON.parse(json);
        } catch (ex) {
        Severity: Minor
        Found in ui/controllers/bagit_profile_controller.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Invalid

                try {
            obj = JSON.parse(json);
        } catch (ex) {
            let msg = Context.y18n.__("Error parsing JSON: %s. ", ex.message || ex);
            if (profileUrl) {
        Severity: Major
        Found in ui/controllers/bagit_profile_controller.js and 1 other location - About 2 hrs to fix
        ui/controllers/settings_controller.js on lines 440..448

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 86.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Invalid

                if (!Util.isEmpty(profile.errors["manifestsAllowed"])) {
            errors.push(Context.y18n.__("Manifests Tab: %s", profile.errors["manifestsAllowed"]));
        }
        Severity: Major
        Found in ui/controllers/bagit_profile_controller.js and 5 other locations - About 1 hr to fix
        ui/controllers/bagit_profile_controller.js on lines 202..204
        ui/controllers/bagit_profile_controller.js on lines 205..207
        ui/controllers/bagit_profile_controller.js on lines 211..213
        ui/controllers/bagit_profile_controller.js on lines 214..216
        ui/controllers/bagit_profile_controller.js on lines 217..219

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Invalid

                if (!Util.isEmpty(profile.errors["acceptSerialization"])) {
            errors.push(Context.y18n.__("Serialization Tab: %s", profile.errors["acceptSerialization"]));
        }
        Severity: Major
        Found in ui/controllers/bagit_profile_controller.js and 5 other locations - About 1 hr to fix
        ui/controllers/bagit_profile_controller.js on lines 202..204
        ui/controllers/bagit_profile_controller.js on lines 205..207
        ui/controllers/bagit_profile_controller.js on lines 208..210
        ui/controllers/bagit_profile_controller.js on lines 211..213
        ui/controllers/bagit_profile_controller.js on lines 217..219

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Invalid

                if (!Util.isEmpty(profile.errors["tags"])) {
            errors.push(Context.y18n.__("Tag Files Tab: %s", profile.errors["tags"]));
        }
        Severity: Major
        Found in ui/controllers/bagit_profile_controller.js and 5 other locations - About 1 hr to fix
        ui/controllers/bagit_profile_controller.js on lines 202..204
        ui/controllers/bagit_profile_controller.js on lines 205..207
        ui/controllers/bagit_profile_controller.js on lines 208..210
        ui/controllers/bagit_profile_controller.js on lines 211..213
        ui/controllers/bagit_profile_controller.js on lines 214..216

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Invalid

                if (!Util.isEmpty(profile.errors["serialization"])) {
            errors.push(Context.y18n.__("Serialization Tab: %s", profile.errors["serialization"]));
        }
        Severity: Major
        Found in ui/controllers/bagit_profile_controller.js and 5 other locations - About 1 hr to fix
        ui/controllers/bagit_profile_controller.js on lines 202..204
        ui/controllers/bagit_profile_controller.js on lines 205..207
        ui/controllers/bagit_profile_controller.js on lines 208..210
        ui/controllers/bagit_profile_controller.js on lines 214..216
        ui/controllers/bagit_profile_controller.js on lines 217..219

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Invalid

                if (!Util.isEmpty(profile.errors["name"])) {
            errors.push(Context.y18n.__("About Tab: %s", profile.errors["name"]));
        }
        Severity: Major
        Found in ui/controllers/bagit_profile_controller.js and 5 other locations - About 1 hr to fix
        ui/controllers/bagit_profile_controller.js on lines 205..207
        ui/controllers/bagit_profile_controller.js on lines 208..210
        ui/controllers/bagit_profile_controller.js on lines 211..213
        ui/controllers/bagit_profile_controller.js on lines 214..216
        ui/controllers/bagit_profile_controller.js on lines 217..219

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Invalid

                if (!Util.isEmpty(profile.errors["acceptBagItVersion"])) {
            errors.push(Context.y18n.__("General Tab: %s", profile.errors["acceptBagItVersion"]));
        }
        Severity: Major
        Found in ui/controllers/bagit_profile_controller.js and 5 other locations - About 1 hr to fix
        ui/controllers/bagit_profile_controller.js on lines 202..204
        ui/controllers/bagit_profile_controller.js on lines 208..210
        ui/controllers/bagit_profile_controller.js on lines 211..213
        ui/controllers/bagit_profile_controller.js on lines 214..216
        ui/controllers/bagit_profile_controller.js on lines 217..219

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status