Sign upLogin

APTrust/dart

View on GitHub
Star
ui/forms/settings_questions_form.js

Summary

Maintainability
C
1 day
Test Coverage

Function _addObjType has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    _addObjType() {
        let objType = `objType_${this.rowCount}`
        let question = this.obj.questions[this.rowCount];
        let value = question ? question.objType : "";
        this.fields[objType] = new Field(
Severity: Minor
Found in ui/forms/settings_questions_form.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Invalid

        _addField() {
        let field = `field_${this.rowCount}`
        let question = this.obj.questions[this.rowCount];
        let value = "";
        let options = [];
    Severity: Major
    Found in ui/forms/settings_questions_form.js and 1 other location - About 1 day to fix
    ui/forms/settings_questions_form.js on lines 164..190

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 230.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Invalid

        _addObjId() {
        let objId = `objId_${this.rowCount}`
        let question = this.obj.questions[this.rowCount];
        let value = "";
        let options = [];
    Severity: Major
    Found in ui/forms/settings_questions_form.js and 1 other location - About 1 day to fix
    ui/forms/settings_questions_form.js on lines 197..223

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 230.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        getSelectedField(rowNumber) {
        let element = $(`#field_${rowNumber}`);
        return element.length > 0 ? element.val() : this.fields[`field_${rowNumber}`].value;
    }
    Severity: Major
    Found in ui/forms/settings_questions_form.js and 2 other locations - About 2 hrs to fix
    ui/forms/settings_questions_form.js on lines 259..262
    ui/forms/settings_questions_form.js on lines 269..272

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        getSelectedType(rowNumber) {
        let element = $(`#objType_${rowNumber}`);
        return element.length > 0 ? element.val() : this.fields[`objType_${rowNumber}`].value;
    }
    Severity: Major
    Found in ui/forms/settings_questions_form.js and 2 other locations - About 2 hrs to fix
    ui/forms/settings_questions_form.js on lines 269..272
    ui/forms/settings_questions_form.js on lines 279..282

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        getSelectedId(rowNumber) {
        let element = $(`#objId_${rowNumber}`);
        return element.length > 0 ? element.val() : this.fields[`objId_${rowNumber}`].value;
    }
    Severity: Major
    Found in ui/forms/settings_questions_form.js and 2 other locations - About 2 hrs to fix
    ui/forms/settings_questions_form.js on lines 259..262
    ui/forms/settings_questions_form.js on lines 279..282

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Invalid

            if (this.obj.bagItProfiles.length > 0) {
            objTypeOptions.push({
                id: "BagItProfile",
                name: Context.y18n.__("BagIt Profile")
            });
    Severity: Major
    Found in ui/forms/settings_questions_form.js and 3 other locations - About 1 hr to fix
    ui/forms/settings_questions_form.js on lines 123..128
    ui/forms/settings_questions_form.js on lines 135..140
    ui/forms/settings_questions_form.js on lines 141..146

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Invalid

            if (this.obj.storageServices.length > 0) {
            objTypeOptions.push({
                id: "StorageService",
                name: Context.y18n.__("Storage Service")
            });
    Severity: Major
    Found in ui/forms/settings_questions_form.js and 3 other locations - About 1 hr to fix
    ui/forms/settings_questions_form.js on lines 123..128
    ui/forms/settings_questions_form.js on lines 129..134
    ui/forms/settings_questions_form.js on lines 135..140

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Invalid

            if (this.obj.appSettings.length > 0) {
            objTypeOptions.push({
                id: "AppSetting",
                name: Context.y18n.__("App Setting")
            });
    Severity: Major
    Found in ui/forms/settings_questions_form.js and 3 other locations - About 1 hr to fix
    ui/forms/settings_questions_form.js on lines 129..134
    ui/forms/settings_questions_form.js on lines 135..140
    ui/forms/settings_questions_form.js on lines 141..146

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Invalid

            if (this.obj.remoteRepositories.length > 0) {
            objTypeOptions.push({
                id: "RemoteRepository",
                name: Context.y18n.__("Remote Repository")
            });
    Severity: Major
    Found in ui/forms/settings_questions_form.js and 3 other locations - About 1 hr to fix
    ui/forms/settings_questions_form.js on lines 123..128
    ui/forms/settings_questions_form.js on lines 129..134
    ui/forms/settings_questions_form.js on lines 141..146

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status