Aam-Digital/ndb-core

View on GitHub

Comparing master to refactor/remove-old-migrations

Last commit dcd5a321 11 days ago
Compare on GitHub

Function migrateEntityArrayDatatype has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
New

const migrateEntityArrayDatatype: ConfigMigration = (key, configPart) => {
  if (configPart === "DisplayEntityArray") {
    return "DisplayEntity";
  }

Severity: Minor
Found in src/app/core/config/config.service.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File migrate-add-entity-attributes.ts has 517 lines of code (exceeds 250 allowed). Consider refactoring.
Fixed

Severity: Major
Found in src/app/core/config/migrate-add-entity-attributes.ts - About 1 day to fix

    There are no issues that match your filters.

    Category
    Status