Aam-Digital/ndb-core

View on GitHub

Showing 123 of 288 total issues

Avoid too many return statements within this function.
Open

  return entities;
Severity: Major
Found in src/app/core/entity/model/entity-update.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          return order === "asc" ? 1 : -1;
    Severity: Major
    Found in src/app/utils/utils.ts - About 30 mins to fix

      Function initColumnGroups has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        private initColumnGroups(columnGroup?: ColumnGroupsConfig) {
          if (columnGroup && columnGroup.groups.length > 0) {
            this.groups = columnGroup.groups;
            this.defaultColumnGroup =
              columnGroup.default || columnGroup.groups[0].name;
      Severity: Minor
      Found in src/app/core/entity-list/entity-list/entity-list.component.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function parseImportDefinition has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        parseImportDefinition(
          configRaw: ConfigFieldRaw[],
          entityName: string,
          includingDefaultConfigs: boolean,
        ): GeneratedConfig {
      Severity: Minor
      Found in src/app/features/config-setup/config-import-parser.service.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function ngOnChanges has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        ngOnChanges(changes: { [key in keyof this]?: any }) {
          if (changes.valueMapper) {
            this._options.forEach(
              (opt) => (opt.asValue = this.valueMapper(opt.initial)),
            );

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function logToRemoteMonitoring has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        private logToRemoteMonitoring(message: any, logLevel: LogLevel) {
          if (logLevel === LogLevel.ERROR) {
            if (message instanceof Error) {
              Sentry.captureException(message);
            } else {
      Severity: Minor
      Found in src/app/core/logging/logging.service.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function loadActivities has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        private async loadActivities() {
          this.allActivities = await this.entityMapper
            .loadType(RecurringActivity)
            .then((res) => res.filter((a) => a.isActive));
      
      

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function printObjectDifferences has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function printObjectDifferences(name: string, obj1: object, obj2: object) {
        for (const attr in obj1) {
          if (!obj1.hasOwnProperty(attr)) {
            continue;
          }
      Severity: Minor
      Found in src/app/utils/expect-entity-data.spec.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function parseFieldDefinition has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        private parseFieldDefinition(
          fieldDef: ConfigFieldRaw,
          entityType: string,
        ): { id: string; schema: EntitySchemaField } {
          const fieldId = fieldDef.id ?? generateIdFromLabel(fieldDef.label);
      Severity: Minor
      Found in src/app/features/config-setup/config-import-parser.service.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function loadParticipants has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        private async loadParticipants() {
          this.children = [];
          this.inactiveParticipants = [];
          for (const childId of this.eventEntity.children) {
            let child: Child;

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function setEntityConfig has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        private setEntityConfig(newConfig: Config) {
          const entityConfigKey =
            EntityConfigService.PREFIX_ENTITY_CONFIG + this.entityType;
      
          // init config if not present
      Severity: Minor
      Found in src/app/core/admin/admin-entity/admin-entity.component.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function generateRows has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        private generateRows(
          data: any[],
          config: ExportColumnConfig[],
          from: Date,
          to: Date,

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function makeCustomMatcher has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      export function makeCustomMatcher<T>(
        condition: (actual: T, ...expected: any[]) => boolean,
        compareMessage: (actual: T, ...expected: any[]) => string,
        negativeCompareMessage: (actual: T, ...expected: any[]) => string,
      ): jasmine.CustomMatcher {
      Severity: Minor
      Found in src/app/utils/test-utils/custom-matcher-utils.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function compareValues has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function compareValues(a, b) {
        if (a === b) {
          return 0;
        } else if (typeof a === "string" && typeof b === "string") {
          return a.localeCompare(b, undefined, { numeric: true });
      Severity: Minor
      Found in src/app/core/common-components/entities-table/table-sort/table-sort.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getDaysSinceLastNoteOfEachEntity has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        public async getDaysSinceLastNoteOfEachEntity(
          entityType = Child.ENTITY_TYPE,
          forLastNDays: number = 30,
        ): Promise<Map<string, number>> {
          const startDay = moment().subtract(forLastNDays, "days");
      Severity: Minor
      Found in src/app/child-dev-project/children/children.service.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getValueDescription has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function getValueDescription(value: any, property: string): string {
        if (typeof value === "boolean") {
          return value
            ? property
            : $localize`:Not a certain property|e.g. 'not male':not ${property}`;
      Severity: Minor
      Found in src/app/features/reporting/report-row.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function applyTextToCreatedEntity has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      export function applyTextToCreatedEntity(entity: Entity, input: string) {
        const toStringFields = entity.getConstructor().toStringAttributes;
        if (!toStringFields || toStringFields.length < 1) {
          return;
        }
      Severity: Minor
      Found in src/app/core/common-components/entity-select/entity-select.component.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function generateSchema has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        generateSchema(): SqsSchema {
          const tables: SqlTables = {};
          for (const [name, ctr] of this.entities.entries()) {
            tables[name] = {};
            for (const [attr, attrSchema] of ctr.schema) {
      Severity: Minor
      Found in src/app/features/reporting/sql-report/sql-report.service.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getActivitiesForChild has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        async getActivitiesForChild(childId: string): Promise<RecurringActivity[]> {
          const activities = await this.dbIndexing.queryIndexDocs(
            RecurringActivity,
            "activities_index/by_participant",
            childId,
      Severity: Minor
      Found in src/app/child-dev-project/attendance/attendance.service.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getWarningLevel has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        public getWarningLevel(forChildId?: string): WarningLevel {
          let attendancePercentage;
          if (forChildId) {
            attendancePercentage = this.getAttendancePercentage(forChildId);
          } else {
      Severity: Minor
      Found in src/app/child-dev-project/attendance/model/activity-attendance.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language