Class Organisation has 28 methods (exceeds 20 allowed). Consider refactoring.

Open

class Organisation < BaseOrganisation

  has_many :volunteer_ops
  has_many :users
  has_many :edits, class_name: 'ProposedOrganisationEdit', dependent: :destroy

Class ApplicationController has 25 methods (exceeds 20 allowed). Consider refactoring.

Open

class ApplicationController < ActionController::Base
  protect_from_forgery
  before_action :store_location,
                :assign_footer_page_links,
                :set_tags,

Class VolunteerOpsController has 23 methods (exceeds 20 allowed). Consider refactoring.

Open

class VolunteerOpsController < ApplicationController
  layout :choose_layout

  before_action :set_organisation, only: [:new, :create]
  before_action :authorize, except: [:search, :show, :index]

Function initMap has 56 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  initMap: function initMap() {
    Settings.zoom = parseInt($("#marker_data").data().zoom || '12', 10)
    Settings.lat = parseFloat($("#marker_data").data().latitude || '51.5978')
    Settings.lng = parseFloat($("#marker_data").data().longitude || '-0.3370')
    Settings.geojsonUrl1 = $("#marker_data").data().geojsonUrl1 

Function invite_users has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    $.fn.invite_users = function () {
        $(this).click(function () {
            var values = {},
                checks = $('input:checked');
            checks.each(function () {

Method <=> has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    def <=> other
      if (@sym == :what_they_do && other.sym == :how_they_help) || (@sym == :what_they_do && other.sym == :who_they_help) ||
        (@sym == :who_they_help && other.sym == :how_they_help)
        -1
      elsif @sym == other.sym

• Read up
  Read up

Consider simplifying this complex logical expression.

Open

      if (@sym == :what_they_do && other.sym == :how_they_help) || (@sym == :what_they_do && other.sym == :who_they_help) ||
        (@sym == :who_they_help && other.sym == :how_they_help)
        -1
      elsif @sym == other.sym
        0

Method with has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

  def self.with(listener, params, model_klass = ProposedOrganisationEdit, user_klass = User, mailer_klass = AdminMailer)

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

  def initialize(listener, params, model_klass, user_klass, mailer_klass)

Method create_and_validate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

  def self.create_and_validate(attributes)
    # create!(attributes.select{|k,v| !v.nil?})
    create!(attributes.each { |k, v| attributes[k] =v.nil? ? 'No information recorded' : (v.empty? ? 'No information recorded' : v) })
  end

• Read up
  Read up

Method build_map_markers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

  def build_map_markers(organisations)
    ::MapMarkerJson.build(organisations) do |org, marker|
      marker.lat org.latitude
      marker.lng org.longitude
      marker.infowindow render_to_string(partial: 'organisations/popup', locals: {org: org})

• Read up
  Read up

Method show has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

  def show
    render template: 'pages/404', status: 404 and return if @organisation.nil?
    organisations = Organisation.where(id: @organisation.id)
    @user_opts = current_user ? get_user_options(@organisation) : { grabbable: true }
    @user_opts[:can_propose_edits] = current_user.present? && !@user_opts[:editable]

• Read up
  Read up

Method render_error has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

  def render_error(status, error)
    raise error unless Rails.env.production?

    Rails.logger.error error.message
    error.backtrace.each_with_index { |line, index| Rails.logger.error line; break if index >= 5 }

• Read up
  Read up