Sign upLogin

AgileVentures/MetPlus_PETS

View on GitHub
Star
app/assets/javascripts/pagination.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function PaginationHandler has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var PaginationHandler = function (url, viewSelector, successCallback, errorCallback, beforeGetCallback) {

    var self = this;

    this.spinner = PETS.spinner;
Severity: Major
Found in app/assets/javascripts/pagination.js - About 3 hrs to fix

    Function PaginationHandler has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

    var PaginationHandler = function (url, viewSelector, successCallback, errorCallback, beforeGetCallback) {

    var self = this;

    this.spinner = PETS.spinner;
    Severity: Minor
    Found in app/assets/javascripts/pagination.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function load_div_from_url has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        this.load_div_from_url = function(target_idx, url) {

        if(typeof self.successCallback == 'undefined')
            self.successCallback = PaginationFunctions.getSuccessFunction(self.name);
        if(typeof self.errorCallback == 'undefined')
    Severity: Minor
    Found in app/assets/javascripts/pagination.js - About 1 hr to fix

      Function PaginationHandler has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      var PaginationHandler = function (url, viewSelector, successCallback, errorCallback, beforeGetCallback) {
      Severity: Minor
      Found in app/assets/javascripts/pagination.js - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status