Sign upLogin

AlbertGazizov/opatch

View on GitHub
Star

Showing 3 of 3 total issues

Method collection has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  def collection(collection_name, options = {}, &block)
    raise ArgumentError, "#{collection_name} collection key should be specified" unless options[:key]
    raise ArgumentError, "#{collection_name} build block should be specified" unless options[:build]
    # Todo: ensure key is a symbol or array of symbols, block is proc
    key         = options[:key]
Severity: Minor
Found in lib/o_patch/patcher.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method object has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def object(field_name, options = {}, &block)
    if attributes.has_key?(field_name)
      if attributes[field_name].nil?
        remove_block = options[:remove]
        if remove_block
Severity: Minor
Found in lib/o_patch/patcher.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method field has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def field(field_name, block = nil)
    raise ArgumentError, "field name should be a symbol" unless field_name.is_a?(Symbol)
    if attributes.has_key?(field_name)
      value = attributes[field_name]
      if block
Severity: Minor
Found in lib/o_patch/patcher.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language