Sign upLogin

AlexeyDemidov/bigdoorkit-ruby

View on GitHub
Star

Showing 3 of 11 total issues

Method add_required_params has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        def add_required_params( method, params, payload )
            raise ArgumentError.new('unkown method') unless [:get, :put, :post, :delete].include?(method)

            params = {} unless params
            payload = {} unless payload
Severity: Minor
Found in lib/big_door/client.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method flatten_params has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        def flatten_params( params )
            raise ArgumentError.new('params should be defined') unless params
            result = ''
            keys = params.keys.sort{|a,b| a.to_s <=> b.to_s}
            keys.each do |key|
Severity: Minor
Found in lib/big_door/client.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method do_request has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def do_request( method, end_point, params = nil, payload = nil )
            headers = {
                'User-Agent' => "BigDoorKit-Ruby/#{VERSION}",
            }
Severity: Minor
Found in lib/big_door/client.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language