AndrewWalsh/at-your-service

View on GitHub
demo/public/at-your-service-sw.js

Summary

Maintainability
D
3 days
Test Coverage

Function _createPayload has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async _createPayload(event, response, beforeRequestTime, afterRequestTime, requestBody) {
    const request = event.request
    const requestHeaders = {};
    for (const [key, value] of request.headers) {
      requestHeaders[key] = value;
Severity: Minor
Found in demo/public/at-your-service-sw.js - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    class FetchPayload {
      /**
       * Used as the message payload to the client
       * @param {Event} event - a fetch event
       * @param {Response} response - a response object from a fetch event
    Severity: Major
    Found in demo/public/at-your-service-sw.js and 1 other location - About 2 days to fix
    docs/at-your-service-sw.js on lines 1..84

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 456.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    async function postMessageToAYS(event, type, payload) {
      const thisClient = await self.clients.get(event.clientId);
      if (thisClient) {
        thisClient.postMessage({ type, payload });
        thisClient
    Severity: Major
    Found in demo/public/at-your-service-sw.js and 1 other location - About 1 hr to fix
    docs/at-your-service-sw.js on lines 92..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 70.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status