Apollon77/smartmeter-obis

View on GitHub
lib/transports/SerialResponseTransport.js

Summary

Maintainability
D
1 day
Test Coverage
B
83%

Function processData has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

SerialResponseTransport.prototype.processData = function processData() {
    var self = this;
    if (!self.currentData || self.currentData.length === 0) return false;
    if (self.protocol.checkMessage(self.currentData.slice(0, self.currentDataOffset))) {
        if (self.messageTimeoutTimer) {
Severity: Minor
Found in lib/transports/SerialResponseTransport.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function init has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

SerialResponseTransport.prototype.init = function init() {
    this.protocol.initState(); // init State from protocol instance

    var self = this;
    if (!this.serialComm) {
Severity: Major
Found in lib/transports/SerialResponseTransport.js - About 3 hrs to fix

    Function scheduleNextRun has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Wontfix

    SerialResponseTransport.prototype.scheduleNextRun = function scheduleNextRun() {
        var self = this;
        if (!this.stopRequests) {
            if (this.requestTimer) {
                clearTimeout(this.requestTimer);
    Severity: Minor
    Found in lib/transports/SerialResponseTransport.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function 'processData' has too many statements (38). Maximum allowed is 30.
    Wontfix

    SerialResponseTransport.prototype.processData = function processData() {

    enforce a maximum number of statements allowed in function blocks (max-statements)

    The max-statements rule allows you to specify the maximum number of statements allowed in a function.

    function foo() {
      var bar = 1; // one statement
      var baz = 2; // two statements
      var qux = 3; // three statements
    }

    Rule Details

    This rule enforces a maximum number of statements allowed in function blocks.

    Options

    This rule has a number or object option:

    • "max" (default 10) enforces a maximum number of statements allows in function blocks

    Deprecated: The object property maximum is deprecated; please use the object property max instead.

    This rule has an object option:

    • "ignoreTopLevelFunctions": true ignores top-level functions

    max

    Examples of incorrect code for this rule with the default { "max": 10 } option:

    /*eslint max-statements: ["error", 10]*/
    /*eslint-env es6*/
    
    function foo() {
      var foo1 = 1;
      var foo2 = 2;
      var foo3 = 3;
      var foo4 = 4;
      var foo5 = 5;
      var foo6 = 6;
      var foo7 = 7;
      var foo8 = 8;
      var foo9 = 9;
      var foo10 = 10;
    
      var foo11 = 11; // Too many.
    }
    
    let foo = () => {
      var foo1 = 1;
      var foo2 = 2;
      var foo3 = 3;
      var foo4 = 4;
      var foo5 = 5;
      var foo6 = 6;
      var foo7 = 7;
      var foo8 = 8;
      var foo9 = 9;
      var foo10 = 10;
    
      var foo11 = 11; // Too many.
    };

    Examples of correct code for this rule with the default { "max": 10 } option:

    /*eslint max-statements: ["error", 10]*/
    /*eslint-env es6*/
    
    function foo() {
      var foo1 = 1;
      var foo2 = 2;
      var foo3 = 3;
      var foo4 = 4;
      var foo5 = 5;
      var foo6 = 6;
      var foo7 = 7;
      var foo8 = 8;
      var foo9 = 9;
      var foo10 = 10;
      return function () {
    
        // The number of statements in the inner function does not count toward the
        // statement maximum.
    
        return 42;
      };
    }
    
    let foo = () => {
      var foo1 = 1;
      var foo2 = 2;
      var foo3 = 3;
      var foo4 = 4;
      var foo5 = 5;
      var foo6 = 6;
      var foo7 = 7;
      var foo8 = 8;
      var foo9 = 9;
      var foo10 = 10;
      return function () {
    
        // The number of statements in the inner function does not count toward the
        // statement maximum.
    
        return 42;
      };
    }

    ignoreTopLevelFunctions

    Examples of additional correct code for this rule with the { "max": 10 }, { "ignoreTopLevelFunctions": true } options:

    /*eslint max-statements: ["error", 10, { "ignoreTopLevelFunctions": true }]*/
    
    function foo() {
      var foo1 = 1;
      var foo2 = 2;
      var foo3 = 3;
      var foo4 = 4;
      var foo5 = 5;
      var foo6 = 6;
      var foo7 = 7;
      var foo8 = 8;
      var foo9 = 9;
      var foo10 = 10;
      var foo11 = 11;
    }

    Related Rules

    • [complexity](complexity.md)
    • [max-depth](max-depth.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md) Source: http://eslint.org/docs/rules/

    File SerialResponseTransport.js has 265 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* jshint -W097 */
    // jshint strict:true
    /*jslint node: true */
    /*jslint esversion: 6 */
    'use strict';
    Severity: Minor
    Found in lib/transports/SerialResponseTransport.js - About 2 hrs to fix

      Function processData has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      SerialResponseTransport.prototype.processData = function processData() {
          var self = this;
          if (!self.currentData || self.currentData.length === 0) return false;
          if (self.protocol.checkMessage(self.currentData.slice(0, self.currentDataOffset))) {
              if (self.messageTimeoutTimer) {
      Severity: Major
      Found in lib/transports/SerialResponseTransport.js - About 2 hrs to fix

        Function has too many statements (31). Maximum allowed is 30.
        Wontfix

                this.serialComm.on('data', function (data) {

        enforce a maximum number of statements allowed in function blocks (max-statements)

        The max-statements rule allows you to specify the maximum number of statements allowed in a function.

        function foo() {
          var bar = 1; // one statement
          var baz = 2; // two statements
          var qux = 3; // three statements
        }

        Rule Details

        This rule enforces a maximum number of statements allowed in function blocks.

        Options

        This rule has a number or object option:

        • "max" (default 10) enforces a maximum number of statements allows in function blocks

        Deprecated: The object property maximum is deprecated; please use the object property max instead.

        This rule has an object option:

        • "ignoreTopLevelFunctions": true ignores top-level functions

        max

        Examples of incorrect code for this rule with the default { "max": 10 } option:

        /*eslint max-statements: ["error", 10]*/
        /*eslint-env es6*/
        
        function foo() {
          var foo1 = 1;
          var foo2 = 2;
          var foo3 = 3;
          var foo4 = 4;
          var foo5 = 5;
          var foo6 = 6;
          var foo7 = 7;
          var foo8 = 8;
          var foo9 = 9;
          var foo10 = 10;
        
          var foo11 = 11; // Too many.
        }
        
        let foo = () => {
          var foo1 = 1;
          var foo2 = 2;
          var foo3 = 3;
          var foo4 = 4;
          var foo5 = 5;
          var foo6 = 6;
          var foo7 = 7;
          var foo8 = 8;
          var foo9 = 9;
          var foo10 = 10;
        
          var foo11 = 11; // Too many.
        };

        Examples of correct code for this rule with the default { "max": 10 } option:

        /*eslint max-statements: ["error", 10]*/
        /*eslint-env es6*/
        
        function foo() {
          var foo1 = 1;
          var foo2 = 2;
          var foo3 = 3;
          var foo4 = 4;
          var foo5 = 5;
          var foo6 = 6;
          var foo7 = 7;
          var foo8 = 8;
          var foo9 = 9;
          var foo10 = 10;
          return function () {
        
            // The number of statements in the inner function does not count toward the
            // statement maximum.
        
            return 42;
          };
        }
        
        let foo = () => {
          var foo1 = 1;
          var foo2 = 2;
          var foo3 = 3;
          var foo4 = 4;
          var foo5 = 5;
          var foo6 = 6;
          var foo7 = 7;
          var foo8 = 8;
          var foo9 = 9;
          var foo10 = 10;
          return function () {
        
            // The number of statements in the inner function does not count toward the
            // statement maximum.
        
            return 42;
          };
        }

        ignoreTopLevelFunctions

        Examples of additional correct code for this rule with the { "max": 10 }, { "ignoreTopLevelFunctions": true } options:

        /*eslint max-statements: ["error", 10, { "ignoreTopLevelFunctions": true }]*/
        
        function foo() {
          var foo1 = 1;
          var foo2 = 2;
          var foo3 = 3;
          var foo4 = 4;
          var foo5 = 5;
          var foo6 = 6;
          var foo7 = 7;
          var foo8 = 8;
          var foo9 = 9;
          var foo10 = 10;
          var foo11 = 11;
        }

        Related Rules

        • [complexity](complexity.md)
        • [max-depth](max-depth.md)
        • [max-len](max-len.md)
        • [max-nested-callbacks](max-nested-callbacks.md)
        • [max-params](max-params.md) Source: http://eslint.org/docs/rules/

        Function scheduleNextRun has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        SerialResponseTransport.prototype.scheduleNextRun = function scheduleNextRun() {
            var self = this;
            if (!this.stopRequests) {
                if (this.requestTimer) {
                    clearTimeout(this.requestTimer);
        Severity: Minor
        Found in lib/transports/SerialResponseTransport.js - About 1 hr to fix

          Function process has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          SerialResponseTransport.prototype.process = function process() {
              var self = this;
              function startIt() {
                  if (self.messageTimeoutTimer) {
                      clearTimeout(self.messageTimeoutTimer);
          Severity: Minor
          Found in lib/transports/SerialResponseTransport.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

              return false;
          Severity: Major
          Found in lib/transports/SerialResponseTransport.js - About 30 mins to fix

            Function stop has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            SerialResponseTransport.prototype.stop = function stop(callback) {
                this.stopRequests = true;
                if (this.requestTimer) {
                    clearTimeout(this.requestTimer);
                    this.requestTimer = null;
            Severity: Minor
            Found in lib/transports/SerialResponseTransport.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function SerialResponseTransport has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Wontfix

            function SerialResponseTransport(options, protocol) {
                this.options = options;
                this.protocol = protocol;
                this.serialConnected = false;
                this.serialComm = undefined;
            Severity: Minor
            Found in lib/transports/SerialResponseTransport.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Expected return with your callback function.
            Open

                        if (callback) callback();

            Enforce Return After Callback (callback-return)

            The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

            function doSomething(err, callback) {
                if (err) {
                    return callback(err);
                }
                callback();
            }

            To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

            Rule Details

            This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

            Options

            The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

            Default callback names

            Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    callback(err);
                }
                callback();
            }

            Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    return callback(err);
                }
                callback();
            }

            Supplied callback names

            Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

            /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
            
            function foo(err, done) {
                if (err) {
                    done(err);
                }
                done();
            }
            
            function bar(err, send) {
                if (err) {
                    send.error(err);
                }
                send.success();
            }

            Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

            /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
            
            function foo(err, done) {
                if (err) {
                    return done(err);
                }
                done();
            }
            
            function bar(err, send) {
                if (err) {
                    return send.error(err);
                }
                send.success();
            }

            Known Limitations

            Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

            • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
            • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

            Passing the callback by reference

            The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

            Example of a false negative when this rule reports correct code:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    setTimeout(callback, 0); // this is bad, but WILL NOT warn
                }
                callback();
            }

            Triggering the callback within a nested function

            The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

            Example of a false negative when this rule reports correct code:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    process.nextTick(function() {
                        return callback(); // this is bad, but WILL NOT warn
                    });
                }
                callback();
            }

            If/else statements

            The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

            Example of a false positive when this rule reports incorrect code:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    callback(err); // this is fine, but WILL warn
                } else {
                    callback();    // this is fine, but WILL warn
                }
            }

            When Not To Use It

            There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

            Further Reading

            Related Rules

            Expected return with your callback function.
            Open

                    if (callback) callback();

            Enforce Return After Callback (callback-return)

            The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

            function doSomething(err, callback) {
                if (err) {
                    return callback(err);
                }
                callback();
            }

            To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

            Rule Details

            This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

            Options

            The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

            Default callback names

            Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    callback(err);
                }
                callback();
            }

            Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    return callback(err);
                }
                callback();
            }

            Supplied callback names

            Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

            /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
            
            function foo(err, done) {
                if (err) {
                    done(err);
                }
                done();
            }
            
            function bar(err, send) {
                if (err) {
                    send.error(err);
                }
                send.success();
            }

            Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

            /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
            
            function foo(err, done) {
                if (err) {
                    return done(err);
                }
                done();
            }
            
            function bar(err, send) {
                if (err) {
                    return send.error(err);
                }
                send.success();
            }

            Known Limitations

            Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

            • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
            • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

            Passing the callback by reference

            The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

            Example of a false negative when this rule reports correct code:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    setTimeout(callback, 0); // this is bad, but WILL NOT warn
                }
                callback();
            }

            Triggering the callback within a nested function

            The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

            Example of a false negative when this rule reports correct code:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    process.nextTick(function() {
                        return callback(); // this is bad, but WILL NOT warn
                    });
                }
                callback();
            }

            If/else statements

            The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

            Example of a false positive when this rule reports incorrect code:

            /*eslint callback-return: "error"*/
            
            function foo(err, callback) {
                if (err) {
                    callback(err); // this is fine, but WILL warn
                } else {
                    callback();    // this is fine, but WILL warn
                }
            }

            When Not To Use It

            There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

            Further Reading

            Related Rules

            There are no issues that match your filters.

            Category
            Status