Aragas/Bannerlord.MBOptionScreen

View on GitHub

Showing 4 of 153 total issues

Method HandleInput has a Cognitive Complexity of 72 (exceeds 20 allowed). Consider refactoring.
Open

        public override void HandleInput(IReadOnlyList<int> lastKeysPressed)
        {
            if (Input.IsKeyDown(InputKey.LeftControl) && Input.IsKeyPressed(InputKey.V))
            {
                base.HandleInput(lastKeysPressed);
Severity: Minor
Found in src/MCM.UI/GUI/Views/EditValueTextWidget.cs - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Create has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

            string? titleText, string? text, bool isAffirmativeOptionShown, bool isNegativeOptionShown, string? affirmativeText, string? negativeText,
            Action affirmativeAction, Action negativeAction, string soundEventPath = "")
Severity: Major
Found in src/MCM.UI/Utils/InquiryDataUtils.cs - About 1 hr to fix

    Method AddButton has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            public ISettingsPropertyGroupBuilder AddButton(string id, string name, IRef @ref, string content, Action<ISettingsPropertyButtonBuilder>? builder)

      Method AddButton has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              ISettingsPropertyGroupBuilder AddButton(string id, string name, IRef @ref, string content, Action<ISettingsPropertyButtonBuilder>? builder);
      Severity: Minor
      Found in src/MCM/Abstractions/FluentBuilder/ISettingsPropertyGroupBuilder.cs - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language