Arie/serveme

View on GitHub

Showing 39 of 43 total issues

Method save_version_info has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def save_version_info(server_info)
    return unless server_info&.version.present?

    if server_info.version < self.class.latest_version
      Rails.logger.warn("Server #{name} was updating since #{I18n.l(update_started_at, format: :short)} but is now back online with old version #{server_info.version} instead of latest #{self.class.latest_version}") if update_status == 'Updating'
Severity: Minor
Found in app/models/server.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def create
    respond_to do |format|
      format.html do
        render :new, status: :unprocessable_entity if params[:file_upload].nil? && return

Severity: Minor
Found in app/controllers/file_uploads_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def create
    respond_to do |format|
      format.html do
        render :new, status: :unprocessable_entity if params[:map_upload].nil? && return

Severity: Minor
Found in app/controllers/map_uploads_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method new has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def new
    respond_to do |format|
      if params[:ip] || params[:steam_uid]
        @results = LeagueRequest.new(current_user, ip: params[:ip], steam_uid: params[:steam_uid], reservation_ids: params[:reservation_ids], cross_reference: params[:cross_reference]).search
        if @results
Severity: Minor
Found in app/controllers/league_requests_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method stripe has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def stripe
    $lock.synchronize("stripe-charge-#{current_user.id}") do
      if params[:stripe_token] && params[:product_id] && params[:gift]
        order = current_user.stripe_orders.build
        order.payer_id = params[:stripe_token]
Severity: Minor
Found in app/controllers/orders_controller.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method authenticate_user! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def authenticate_user!
    if user_signed_in?
      if current_user.banned?
        Rails.logger.info "Logging out banned player with user id #{current_user.id} steam uid #{current_user.uid}, IP #{current_user.current_sign_in_ip}, name #{current_user.name}"
        sign_out_and_redirect(current_user)
Severity: Minor
Found in app/controllers/application_controller.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method extract_zip_to_tmp_dir has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def extract_zip_to_tmp_dir
    files_with_path = {}
    Zip::File.foreach(file.file.file) do |zipped_file|
      filename = File.basename(zipped_file.name)
      Dir.mkdir(File.join(tmp_dir, zipped_file.name)) if zipped_file.directory?
Severity: Minor
Found in app/models/file_upload.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method remove_banned_players has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def remove_banned_players
    parser.players.each do |player|
      next unless banned_player?(player)

      uid3 = SteamCondenser::Community::SteamId.community_id_to_steam_id3(player.steam_uid.to_i)
Severity: Minor
Found in app/services/server_metric.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method perform has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def perform(steam_uid)
    return unless steam_uid =~ /^7656\d+$/

    @steam_uid = steam_uid
    begin
Severity: Minor
Found in app/workers/update_steam_nickname_worker.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method restart has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def restart
    page = agent.get(control_url)
    if page.code == '302'
      login
      page = agent.get(control_url)
Severity: Minor
Found in app/services/nfo_control_panel.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

    return 'Ready' if server_statistics.any? && !server.sdr?
Severity: Major
Found in app/models/reservation.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

        return 'Starting' if status_messages.include?('Starting')
    Severity: Major
    Found in app/models/reservation.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return 'Server updating, please be patient' if status_messages.grep(/\AServer outdated/).any?
      Severity: Major
      Found in app/models/reservation.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return 'Ready' if status_messages.grep(/\AServer finished loading map/).any? && !server.sdr?
        Severity: Major
        Found in app/models/reservation.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return 'Waiting to start' if status_messages.include?('Waiting to start')
          Severity: Major
          Found in app/models/reservation.rb - About 30 mins to fix

            Method find_reservation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def find_reservation(reservation_id)
                played_in_reservation = Reservation.played_in(current_user.uid).where(id: reservation_id).first
                if played_in_reservation.nil? && (current_user.admin? || current_user.league_admin? || current_user.streamer?)
                  reservation = Reservation.find(reservation_id)
                  Rails.logger.info("ZIP download by #{current_user.name} (#{current_user.uid}) for reservation #{reservation.id} made by #{reservation&.user&.uid}") if reservation
            Severity: Minor
            Found in app/controllers/uploads_controller.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method ssh_exec has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def ssh_exec(command, log_stderr: false)
                out = []
                err = []
                ssh.exec!(command) do |_channel, stream, data|
                  out << data if stream == :stdout
            Severity: Minor
            Found in app/models/ssh_server.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method reservations_scope has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def reservations_scope
                  if api_user.admin? || api_user.trusted_api?
                    if params[:steam_uid]
                      Reservation.joins(:user).where(users: { uid: params[:steam_uid] })
                    else
            Severity: Minor
            Found in app/controllers/api/reservations_controller.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method rcon_exec has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def rcon_exec(command, allow_blocked: false)
                return nil if blocked_command?(command) && !allow_blocked
            
                condenser.rcon_exec(command) if rcon_auth
              rescue Errno::ECONNREFUSED, SteamCondenser::Error::Timeout, SteamCondenser::Error::RCONNoAuth, SteamCondenser::Error::RCONBan => e
            Severity: Minor
            Found in app/models/server.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language