Sign upLogin

ArtemRakov/frontend-project-lvl2

View on GitHub
Star

Showing 3 of 5 total issues

Function buildDiff has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

const buildDiff = (before, after) => {
  const buildNode = (key) => {
    const beforeValue = before[key];
    const afterValue = after[key];
Severity: Minor
Found in src/diff.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return {
      key, beforeValue, afterValue, type: 'changed',
    };
Severity: Major
Found in src/diff.js - About 30 mins to fix

    Function iniParse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    const iniParse = (data) => {
  const REGEX_FOR_NUMBER = /^-?[\d.]+(?:e-?\d+)?$/;
  const parsedData = ini.parse(data);

  const objectParse = (object) => {
    Severity: Minor
    Found in src/parsers.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language