Sign upLogin

Asymmetrik/mean2-starter

View on GitHub
Star
src/server/app/admin/controllers/users/users.password.server.controller.js

Summary

Maintainability
D
2 days
Test Coverage

Function reset has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.reset = (req, res, next) => {

    // Init Variables
    let password = req.body.password;
Severity: Major
Found in src/server/app/admin/controllers/users/users.password.server.controller.js - About 2 hrs to fix

    Function forgot has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.forgot = (req, res, next) => {

    // Make sure there is a username
    if(null == req.body.username) {
        return res.status(400).json({ message: 'Username is missing.' });
    Severity: Major
    Found in src/server/app/admin/controllers/users/users.password.server.controller.js - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              (emailHTML, user, done) => {
            let mailOptions = {
                to: user.email,
                from: config.mailer.from,
                subject: 'Your password has been changed',
      Severity: Major
      Found in src/server/app/admin/controllers/users/users.password.server.controller.js and 1 other location - About 7 hrs to fix
      src/server/app/admin/controllers/users/users.password.server.controller.js on lines 82..100

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 186.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              (emailHTML, user, done) => {
            let mailOptions = {
                to: user.email,
                from: config.mailer.from,
                subject: 'Password Reset',
      Severity: Major
      Found in src/server/app/admin/controllers/users/users.password.server.controller.js and 1 other location - About 7 hrs to fix
      src/server/app/admin/controllers/users/users.password.server.controller.js on lines 191..208

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 186.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      let
    async = require('async'),
    crypto = require('crypto'),
    path = require('path'),
      Severity: Major
      Found in src/server/app/admin/controllers/users/users.password.server.controller.js and 1 other location - About 1 hr to fix
      src/server/app/admin/controllers/users/users.profile.server.controller.js on lines 3..14

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status