Sign upLogin

Asymmetrik/mean2-starter

View on GitHub
Star
src/server/app/admin/controllers/users/users.profile.server.controller.js

Summary

Maintainability
D
2 days
Test Coverage

Function updateCurrentUser has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.updateCurrentUser = (req, res) => {

    // Make sure the user is logged in
    if (null == req.user){
        res.status(400).json({
Severity: Minor
Found in src/server/app/admin/controllers/users/users.profile.server.controller.js - About 1 hr to fix

    Function matchUsers has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.matchUsers = (req, res) => {
    // Handle the query/search/page
    let query = req.body.q;
    let search = req.body.s;
    Severity: Minor
    Found in src/server/app/admin/controllers/users/users.profile.server.controller.js - About 1 hr to fix

      Function searchUsers has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function searchUsers(req, res, copyUserFn) {

    // Handle the query/search/page
    let query = req.body.q;
    let search = req.body.s;
      Severity: Minor
      Found in src/server/app/admin/controllers/users/users.profile.server.controller.js - About 1 hr to fix

        Function adminUpdateUser has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.adminUpdateUser = (req, res) => {

    // The persistence user
    let user = req.userParam;
        Severity: Minor
        Found in src/server/app/admin/controllers/users/users.profile.server.controller.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          exports.adminGetUser = (req, res) => {

    // The user that is a parameter of the request is stored in 'userParam'
    let user = req.userParam;
          Severity: Major
          Found in src/server/app/admin/controllers/users/users.profile.server.controller.js and 1 other location - About 3 hrs to fix
          src/server/app/admin/controllers/users/users.profile.server.controller.js on lines 82..95

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 100.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          exports.getCurrentUser = (req, res) => {

    // The user that is a parameter of the request is stored in 'userParam'
    let user = req.user;
          Severity: Major
          Found in src/server/app/admin/controllers/users/users.profile.server.controller.js and 1 other location - About 3 hrs to fix
          src/server/app/admin/controllers/users/users.profile.server.controller.js on lines 256..269

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 100.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      auditService.audit('admin user updated', 'user', 'admin update',
                User.auditCopy(req.user, util.getHeaderField(req.headers, 'x-real-ip')),
                { before: originalUser, after: User.auditCopy(user) }, req.headers);
          Severity: Major
          Found in src/server/app/admin/controllers/users/users.profile.server.controller.js and 1 other location - About 1 hr to fix
          src/server/app/messages/controllers/message.server.controller.js on lines 118..120

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          let _ = require('lodash'),
    path = require('path'),
    q = require('q'),

    deps = require(path.resolve('./src/server/dependencies.js')),
          Severity: Major
          Found in src/server/app/admin/controllers/users/users.profile.server.controller.js and 1 other location - About 1 hr to fix
          src/server/app/admin/controllers/users/users.password.server.controller.js on lines 3..15

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      auditService.audit('admin user deleted', 'user', 'admin delete',
                User.auditCopy(req.user, util.getHeaderField(req.headers, 'x-real-ip')),
                User.auditCopy(user), req.headers);
          Severity: Minor
          Found in src/server/app/admin/controllers/users/users.profile.server.controller.js and 1 other location - About 55 mins to fix
          src/server/app/messages/controllers/message.server.controller.js on lines 88..90

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          auditService.audit('user update authentication failed', 'user', 'update authentication failed',
                    User.auditCopy(req.user, util.getHeaderField(req.headers, 'x-real-ip')), {}, req.headers);
          Severity: Minor
          Found in src/server/app/admin/controllers/users/users.profile.server.controller.js and 1 other location - About 30 mins to fix
          src/server/app/admin/controllers/users/eua.server.controller.js on lines 97..98

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status