Asymmetrik/mean2-starter

View on GitHub
src/server/app/teams/services/tags.server.service.js

Summary

Maintainability
F
3 days
Test Coverage

Function exports has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function() {

    /**
     * Copies the mutable fields from src to dest
     *
Severity: Major
Found in src/server/app/teams/services/tags.server.service.js - About 3 hrs to fix

    Function searchTags has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function searchTags(search, query, queryParams, user) {
            let page = util.getPage(queryParams);
            let limit = util.getLimit(queryParams);
    
            let offset = page * limit;
    Severity: Minor
    Found in src/server/app/teams/services/tags.server.service.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              return q()
                  .then(function() {
                      // If user is not an admin, constrain the results to the user's teams
                      if (null == user.roles || !user.roles.admin) {
                          let userObj = user.toObject();
      Severity: Major
      Found in src/server/app/teams/services/tags.server.service.js and 1 other location - About 2 days to fix
      src/server/app/teams/services/teams.server.service.js on lines 279..328

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 396.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          function updateTag(tag, updatedTag, user, headers) {
              // Make a copy of the original tag for a "before" snapshot
              let originalTag = Tag.auditCopy(tag);
      
              // Update the updated date
      Severity: Major
      Found in src/server/app/teams/services/tags.server.service.js and 1 other location - About 5 hrs to fix
      src/server/app/teams/services/teams.server.service.js on lines 223..239

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 139.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

              if (null != queryParams.sort && null != queryParams.dir) {
                  sortArr = [{property: queryParams.sort, direction: queryParams.dir}];
              }
      Severity: Major
      Found in src/server/app/teams/services/tags.server.service.js and 2 other locations - About 1 hr to fix
      src/server/app/teams/services/teams.server.service.js on lines 275..277
      src/server/app/teams/services/teams.server.service.js on lines 339..341

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              return auditService.audit('tag deleted', 'tag', 'delete', TeamMember.auditCopy(user), Tag.auditCopy(tag), headers)
                  .then(function() {
                      // Delete the tag
                      return tag.remove();
                  });
      Severity: Major
      Found in src/server/app/teams/services/tags.server.service.js and 1 other location - About 1 hr to fix
      src/server/app/teams/services/teams.server.service.js on lines 204..208

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status