Sign upLogin

Asymmetrik/mean2-starter

View on GitHub
Star
src/server/app/teams/services/teams.server.service.js

Summary

Maintainability
F
5 days
Test Coverage

Function exports has 250 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function() {

    let teamRolesMap = {
        member: { priority: 1 },
        editor: { priority: 5 },
Severity: Major
Found in src/server/app/teams/services/teams.server.service.js - About 1 day to fix

    Function exports has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function() {

    let teamRolesMap = {
        member: { priority: 1 },
        editor: { priority: 5 },
    Severity: Minor
    Found in src/server/app/teams/services/teams.server.service.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File teams.server.service.js has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

let
    path = require('path'),
    q = require('q'),
    Severity: Minor
    Found in src/server/app/teams/services/teams.server.service.js - About 2 hrs to fix

      Function searchTeams has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function searchTeams(search, query, queryParams, user) {
        let page = util.getPage(queryParams);
        let limit = util.getLimit(queryParams, 1000);

        let offset = page * limit;
      Severity: Minor
      Found in src/server/app/teams/services/teams.server.service.js - About 1 hr to fix

        Function searchTeamMembers has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function searchTeamMembers(search, query, queryParams, team) {
        let page = util.getPage(queryParams);
        let limit = util.getLimit(queryParams);

        let offset = page * limit;
        Severity: Minor
        Found in src/server/app/teams/services/teams.server.service.js - About 1 hr to fix

          Function updateMemberRole has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              function updateMemberRole(user, team, role, requester, headers) {
          Severity: Minor
          Found in src/server/app/teams/services/teams.server.service.js - About 35 mins to fix

            Function addMemberToTeam has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                function addMemberToTeam(user, team, role, requester, headers) {
            Severity: Minor
            Found in src/server/app/teams/services/teams.server.service.js - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      return q()
            .then(function() {
                // If user is not an admin, constrain the results to the user's teams
                if (null == user.roles || !user.roles.admin) {
                    let userObj = user.toObject();
              Severity: Major
              Found in src/server/app/teams/services/teams.server.service.js and 1 other location - About 2 days to fix
              src/server/app/teams/services/tags.server.service.js on lines 119..168

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 396.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  function updateTeam(team, updatedTeam, user, headers) {
        // Make a copy of the original team for auditing purposes
        let originalTeam = Team.auditCopy(team);

        // Update the updated date
              Severity: Major
              Found in src/server/app/teams/services/teams.server.service.js and 1 other location - About 5 hrs to fix
              src/server/app/teams/services/tags.server.service.js on lines 73..89

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 139.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 3 locations. Consider refactoring.
              Open

                      if (null != queryParams.sort && null != queryParams.dir) {
            sortArr = [{property: queryParams.sort, direction: queryParams.dir}];
        }
              Severity: Major
              Found in src/server/app/teams/services/teams.server.service.js and 2 other locations - About 1 hr to fix
              src/server/app/teams/services/tags.server.service.js on lines 115..117
              src/server/app/teams/services/teams.server.service.js on lines 275..277

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 55.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 3 locations. Consider refactoring.
              Open

                      if (null != queryParams.sort && null != queryParams.dir) {
            sortArr = [{property: queryParams.sort, direction: queryParams.dir}];
        }
              Severity: Major
              Found in src/server/app/teams/services/teams.server.service.js and 2 other locations - About 1 hr to fix
              src/server/app/teams/services/tags.server.service.js on lines 115..117
              src/server/app/teams/services/teams.server.service.js on lines 339..341

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 55.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      return auditService.audit('team created', 'team', 'create', TeamMember.auditCopy(creator), Team.auditCopy(newTeam), headers)
            .then(function() {
                // Save the new team
                return newTeam.save();
            })
              Severity: Major
              Found in src/server/app/teams/services/teams.server.service.js and 1 other location - About 1 hr to fix
              src/server/app/teams/services/tags.server.service.js on lines 100..104

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 55.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status