Sign upLogin

Asymmetrik/mean2-starter

View on GitHub
Star
src/server/app/util/services/query.server.service.js

Summary

Maintainability
D
1 day
Test Coverage

Function pagingQuery has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function pagingQuery(schema, find, projection, options, sort, limit, offset, runCount) {

    // Build the query
    var baseQuery = schema.find(find);
    var findQuery = schema.find(find, projection, options).sort(sort).skip(offset).limit(limit).maxscan(config.maxScan);
Severity: Minor
Found in src/server/app/util/services/query.server.service.js - About 1 hr to fix

    Function containsQuery has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    module.exports.containsQuery = function(schema, query, fields, search, limit, offset, sortArr, runCount) {
    Severity: Major
    Found in src/server/app/util/services/query.server.service.js - About 1 hr to fix

      Function pagingQuery has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function pagingQuery(schema, find, projection, options, sort, limit, offset, runCount) {
      Severity: Major
      Found in src/server/app/util/services/query.server.service.js - About 1 hr to fix

        Function search has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        module.exports.search = function(schema, query, searchTerms, limit, offset, sortArr, runCount) {
        Severity: Major
        Found in src/server/app/util/services/query.server.service.js - About 50 mins to fix

          Function stream has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          module.exports.stream = function(schema, query, searchTerms, limit, offset, sortArr, lean) {
          Severity: Major
          Found in src/server/app/util/services/query.server.service.js - About 50 mins to fix

            Function containsQuery has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports.containsQuery = function(schema, query, fields, search, limit, offset, sortArr, runCount) {
    // Initialize find to null
    var find = generateFind(query);
    var projection = {};
    var options = {};
            Severity: Minor
            Found in src/server/app/util/services/query.server.service.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                if(null != searchTerms && '' !== searchTerms){
        find = find || {};
        find.$text = { $search: searchTerms };

        projection = projection || {};
            Severity: Major
            Found in src/server/app/util/services/query.server.service.js and 1 other location - About 3 hrs to fix
            src/server/app/util/services/query.server.service.js on lines 147..156

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 100.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                if(null != searchTerms && '' !== searchTerms){
        find = find || {};
        find.$text = { $search: searchTerms };

        projection = projection || {};
            Severity: Major
            Found in src/server/app/util/services/query.server.service.js and 1 other location - About 3 hrs to fix
            src/server/app/util/services/query.server.service.js on lines 124..133

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 100.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                findQuery.exec(function(error, results){
        if(null != error){
            queryDefer.reject(error);
        } else {
            queryDefer.resolve(results);
            Severity: Major
            Found in src/server/app/util/services/query.server.service.js and 2 other locations - About 1 hr to fix
            src/server/app/util/services/query.server.service.js on lines 53..59
            src/server/app/util/services/query.server.service.js on lines 169..175

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    baseQuery.count(function (error, results) {
            if (null != error) {
                countDefer.reject(error);
            } else {
                countDefer.resolve(results);
            Severity: Major
            Found in src/server/app/util/services/query.server.service.js and 2 other locations - About 1 hr to fix
            src/server/app/util/services/query.server.service.js on lines 64..70
            src/server/app/util/services/query.server.service.js on lines 169..175

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                baseQuery.count(function(error, results){
        if(null != error){
            countDefer.reject(error);
        } else {
            countDefer.resolve(results);
            Severity: Major
            Found in src/server/app/util/services/query.server.service.js and 2 other locations - About 1 hr to fix
            src/server/app/util/services/query.server.service.js on lines 53..59
            src/server/app/util/services/query.server.service.js on lines 64..70

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status