AthensFramework/core

View on GitHub
assets/js/ajax.js

Summary

Maintainability
C
1 day
Test Coverage

Function ajax has 111 lines of code (exceeds 25 allowed). Consider refactoring.
Open

athens.ajax = (function () {

    /**
     * Private method which encapsulates retrieving the CSRFTOKEN global.
     *
Severity: Major
Found in assets/js/ajax.js - About 4 hrs to fix

    Function ajax has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

    athens.ajax = (function () {
    
        /**
         * Private method which encapsulates retrieving the CSRFTOKEN global.
         *
    Severity: Minor
    Found in assets/js/ajax.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function submitForm has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function submitForm(form, success)
        {
            athens.alert.makeAlert("Submitting form.", "info");
    
            if (typeof(success) === 'undefined') {
    Severity: Minor
    Found in assets/js/ajax.js - About 1 hr to fix

      Function done has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              var done = function (data, textStatus, jqXHR) {
                  try {
                      var formPOSTResult = $("<div>" + data + "</div>").find("#" + formId);
      
                      var formHasErrors = formPOSTResult.hasClass("has-errors");
      Severity: Minor
      Found in assets/js/ajax.js - About 1 hr to fix

        Function call has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            var call = function (url, type, settings, data, done, fail) {
        Severity: Minor
        Found in assets/js/ajax.js - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status