Sign upLogin

Athi/athifx

View on GitHub
Star

Showing 4 of 11 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private Function<List<AItem>, AItem> singleAItemFunction(long itemIdToValidate) {
        return aItems -> {
            if (aItems.isEmpty()) {
                throw new AMenuConfigurationException("Item with id: " + itemIdToValidate + " does not exist.");
            } else if (aItems.size() == 1) {
Severity: Minor
Found in athi-fx-gui/src/main/java/com/github/athi/athifx/gui/menu/AGroup.java and 1 other location - About 55 mins to fix
athi-fx-gui/src/main/java/com/github/athi/athifx/gui/menu/AMenu.java on lines 55..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private Function<List<AGroup>, AGroup> singleAGroupFunction(long groupIdToValidate) {
        return aGroups -> {
            if (aGroups.isEmpty()) {
                throw new AMenuConfigurationException("Group with id: " + groupIdToValidate + " does not exist.");
            } else if (aGroups.size() == 1) {
Severity: Minor
Found in athi-fx-gui/src/main/java/com/github/athi/athifx/gui/menu/AMenu.java and 1 other location - About 55 mins to fix
athi-fx-gui/src/main/java/com/github/athi/athifx/gui/menu/AGroup.java on lines 110..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private VBox createLoginBox() {
        VBox loginBox = new VBox();
        Node userIcon = FontAwesome.labelIcon(FontAwesome.USER);
        Label caption = new Label(LOGIN_FIELD_CAPTION, userIcon);
        loginTextField = new TextField();
Severity: Minor
Found in athi-fx-gui/src/main/java/com/github/athi/athifx/gui/application/LoginScreen.java and 1 other location - About 50 mins to fix
athi-fx-gui/src/main/java/com/github/athi/athifx/gui/application/LoginScreen.java on lines 96..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private VBox createPasswordBox() {
        VBox passwordBox = new VBox();
        Node keyIcon = FontAwesome.labelIcon(FontAwesome.KEY);
        Label caption = new Label(PASSWORD_FIELD_CAPTION, keyIcon);
        passwordField = new PasswordField();
Severity: Minor
Found in athi-fx-gui/src/main/java/com/github/athi/athifx/gui/application/LoginScreen.java and 1 other location - About 50 mins to fix
athi-fx-gui/src/main/java/com/github/athi/athifx/gui/application/LoginScreen.java on lines 87..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language