Sign upLogin

AugurProject/augur-ui

View on GitHub
Star
src/modules/app/reducers/app-status.test.js

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  const t5 = {
    description: "Returns the updated value for is mobile",
    assertions: () => {
      const actual = appStatus(DEFAULT_STATE, {
        type: UPDATE_APP_STATUS,
Severity: Major
Found in src/modules/app/reducers/app-status.test.js and 4 other locations - About 2 hrs to fix
src/modules/app/reducers/app-status.test.js on lines 39..56
src/modules/app/reducers/app-status.test.js on lines 58..75
src/modules/app/reducers/app-status.test.js on lines 96..113
src/modules/app/reducers/app-status.test.js on lines 115..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  const t3 = {
    description: "Returns the updated value for has loaded markets",
    assertions: () => {
      const actual = appStatus(DEFAULT_STATE, {
        type: UPDATE_APP_STATUS,
Severity: Major
Found in src/modules/app/reducers/app-status.test.js and 4 other locations - About 2 hrs to fix
src/modules/app/reducers/app-status.test.js on lines 58..75
src/modules/app/reducers/app-status.test.js on lines 77..94
src/modules/app/reducers/app-status.test.js on lines 96..113
src/modules/app/reducers/app-status.test.js on lines 115..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  const t4 = {
    description: "Returns the updated value for is animating",
    assertions: () => {
      const actual = appStatus(DEFAULT_STATE, {
        type: UPDATE_APP_STATUS,
Severity: Major
Found in src/modules/app/reducers/app-status.test.js and 4 other locations - About 2 hrs to fix
src/modules/app/reducers/app-status.test.js on lines 39..56
src/modules/app/reducers/app-status.test.js on lines 77..94
src/modules/app/reducers/app-status.test.js on lines 96..113
src/modules/app/reducers/app-status.test.js on lines 115..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  const t7 = {
    description: "Returns the updated value for transactions loading",
    assertions: () => {
      const actual = appStatus(DEFAULT_STATE, {
        type: UPDATE_APP_STATUS,
Severity: Major
Found in src/modules/app/reducers/app-status.test.js and 4 other locations - About 2 hrs to fix
src/modules/app/reducers/app-status.test.js on lines 39..56
src/modules/app/reducers/app-status.test.js on lines 58..75
src/modules/app/reducers/app-status.test.js on lines 77..94
src/modules/app/reducers/app-status.test.js on lines 96..113

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  const t6 = {
    description: "Returns the updated value for is mobile small",
    assertions: () => {
      const actual = appStatus(DEFAULT_STATE, {
        type: UPDATE_APP_STATUS,
Severity: Major
Found in src/modules/app/reducers/app-status.test.js and 4 other locations - About 2 hrs to fix
src/modules/app/reducers/app-status.test.js on lines 39..56
src/modules/app/reducers/app-status.test.js on lines 58..75
src/modules/app/reducers/app-status.test.js on lines 77..94
src/modules/app/reducers/app-status.test.js on lines 115..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status