Sign upLogin

AugurProject/augur-ui

View on GitHub
Star
src/modules/markets/reducers/markets-data.js

Summary

Maintainability
C
1 day
Test Coverage

Function default has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function(marketsData = DEFAULT_STATE, action) {
  switch (action.type) {
    case UPDATE_MARKETS_DATA: // TODO -- allow for the consumption of partial market objects
      return {
        ...marketsData,
Severity: Major
Found in src/modules/markets/reducers/markets-data.js - About 2 hrs to fix

    Function default has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function(marketsData = DEFAULT_STATE, action) {
  switch (action.type) {
    case UPDATE_MARKETS_DATA: // TODO -- allow for the consumption of partial market objects
      return {
        ...marketsData,
    Severity: Minor
    Found in src/modules/markets/reducers/markets-data.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

          return {
        ...marketsData,
        [marketId]: {
          ...marketsData[marketId],
          ethBalance
    Severity: Major
    Found in src/modules/markets/reducers/markets-data.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            if (!marketId) return marketsData;
      Severity: Major
      Found in src/modules/markets/reducers/markets-data.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              if (!marketId) return marketsData;
        Severity: Major
        Found in src/modules/markets/reducers/markets-data.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return {
        ...marketsData,
        [marketId]: {
          ...marketsData[marketId],
          frozenSharesValue
          Severity: Major
          Found in src/modules/markets/reducers/markets-data.js - About 30 mins to fix

            TODO found
            Open

                case UPDATE_MARKETS_DATA: // TODO -- allow for the consumption of partial market objects
            Severity: Minor
            Found in src/modules/markets/reducers/markets-data.js by fixme

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                case UPDATE_MARKET_CATEGORY: {
      const { marketId, category } = action.data;
      if (!marketId) return marketsData;
      return {
        ...marketsData,
            Severity: Major
            Found in src/modules/markets/reducers/markets-data.js and 3 other locations - About 1 hr to fix
            src/modules/markets/reducers/markets-data.js on lines 42..52
            src/modules/markets/reducers/markets-data.js on lines 53..63
            src/modules/markets/reducers/markets-data.js on lines 64..74

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                case UPDATE_MARKET_ETH_BALANCE: {
      const { marketId, ethBalance } = action.data;
      if (!marketId) return marketsData;
      return {
        ...marketsData,
            Severity: Major
            Found in src/modules/markets/reducers/markets-data.js and 3 other locations - About 1 hr to fix
            src/modules/markets/reducers/markets-data.js on lines 31..41
            src/modules/markets/reducers/markets-data.js on lines 42..52
            src/modules/markets/reducers/markets-data.js on lines 64..74

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                case UPDATE_MARKET_REP_BALANCE: {
      const { marketId, repBalance } = action.data;
      if (!marketId) return marketsData;
      return {
        ...marketsData,
            Severity: Major
            Found in src/modules/markets/reducers/markets-data.js and 3 other locations - About 1 hr to fix
            src/modules/markets/reducers/markets-data.js on lines 31..41
            src/modules/markets/reducers/markets-data.js on lines 53..63
            src/modules/markets/reducers/markets-data.js on lines 64..74

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                case UPDATE_MARKET_FROZEN_SHARES_VALUE: {
      const { marketId, frozenSharesValue } = action.data;
      if (!marketId) return marketsData;
      return {
        ...marketsData,
            Severity: Major
            Found in src/modules/markets/reducers/markets-data.js and 3 other locations - About 1 hr to fix
            src/modules/markets/reducers/markets-data.js on lines 31..41
            src/modules/markets/reducers/markets-data.js on lines 42..52
            src/modules/markets/reducers/markets-data.js on lines 53..63

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status