Sign upLogin

AugurProject/augur-ui

View on GitHub
Star
src/modules/markets/selectors/market.js

Summary

Maintainability
F
1 wk
Test Coverage

Function assembleMarket has a Cognitive Complexity of 108 (exceeds 5 allowed). Consider refactoring.
Open

export function assembleMarket(
  marketId,
  marketData,
  marketLoading,
  marketPriceHistory,
Severity: Minor
Found in src/modules/markets/selectors/market.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function assembleMarket has 354 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function assembleMarket(
  marketId,
  marketData,
  marketLoading,
  marketPriceHistory,
Severity: Major
Found in src/modules/markets/selectors/market.js - About 1 day to fix

    Function marketId has 322 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          (
        marketId,
        marketData,
        marketLoading,
        marketPriceHistory,
    Severity: Major
    Found in src/modules/markets/selectors/market.js - About 1 day to fix

      File market.js has 504 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*
This is one of the most important and sensitive selectors in the app.
It builds the fat, heavy, rigid, hierarchical market objects,
that are used to render and display many parts of the ui.
This is the point where the shallow, light, loose, flexible, independent
      Severity: Major
      Found in src/modules/markets/selectors/market.js - About 1 day to fix

        Function outcomes has 116 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                  .map(outcomeId => {
            const outcomeData = marketOutcomesData[outcomeId];
            const outcomeTradeInProgress =
              marketTradeInProgress && marketTradeInProgress[outcomeId];
            const volume = createBigNumber(outcomeData.volume);
        Severity: Major
        Found in src/modules/markets/selectors/market.js - About 4 hrs to fix

          Consider simplifying this complex logical expression.
          Open

            if (!assembledMarketsCache[marketId]) {
    assembledMarketsCache[marketId] = memoize(
      (
        marketId,
        marketData,
          Severity: Critical
          Found in src/modules/markets/selectors/market.js - About 2 hrs to fix

            Function assembleMarket has 21 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              marketId,
  marketData,
  marketLoading,
  marketPriceHistory,
  isOpen,
            Severity: Major
            Found in src/modules/markets/selectors/market.js - About 2 hrs to fix

              Function selectMarket has 47 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export const selectMarket = marketId => {
  const {
    marketsData,
    marketLoading,
    favorites,
              Severity: Minor
              Found in src/modules/markets/selectors/market.js - About 1 hr to fix

                Function selectMarketReport has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                export const selectMarketReport = (marketId, universeReports) => {
  if (marketId && universeReports) {
    const universeReportsMarketIds = Object.keys(universeReports);
    const numUniverseReports = universeReportsMarketIds.length;
    for (let i = 0; i < numUniverseReports; ++i) {
                Severity: Minor
                Found in src/modules/markets/selectors/market.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                              if (outcome.lastPrice.fullPrecision === "0") {
                outcome.lastPricePercent.formatted = "0";
                outcome.lastPricePercent.full = "0";
              }
                Severity: Minor
                Found in src/modules/markets/selectors/market.js and 1 other location - About 50 mins to fix
                src/modules/markets/selectors/market.js on lines 363..366

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                if (outcome.lastPrice.fullPrecision === "0") {
                  outcome.lastPricePercent.formatted = "0";
                  outcome.lastPricePercent.full = "0";
                }
                Severity: Minor
                Found in src/modules/markets/selectors/market.js and 1 other location - About 50 mins to fix
                src/modules/markets/selectors/market.js on lines 380..383

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status