Sign upLogin

AugurProject/augur-ui

View on GitHub
Star
src/modules/trades/helpers/calc-order-profit-loss-percents.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function default has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function(
  numShares,
  limitPrice,
  side,
  minPrice,
Severity: Major
Found in src/modules/trades/helpers/calc-order-profit-loss-percents.js - About 2 hrs to fix

    Function default has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function(
  numShares,
  limitPrice,
  side,
  minPrice,
    Severity: Minor
    Found in src/modules/trades/helpers/calc-order-profit-loss-percents.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function default has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      numShares,
  limitPrice,
  side,
  minPrice,
  maxPrice,
    Severity: Major
    Found in src/modules/trades/helpers/calc-order-profit-loss-percents.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

        if (
    type === SCALAR &&
    (!minPrice ||
      (!BigNumber.isBigNumber(minPrice) && isNaN(minPrice)) ||
      !maxPrice ||
      Severity: Major
      Found in src/modules/trades/helpers/calc-order-profit-loss-percents.js - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Open

          if (
    !numShares ||
    !sharesFilled ||
    !side ||
    !type ||
        Severity: Major
        Found in src/modules/trades/helpers/calc-order-profit-loss-percents.js - About 40 mins to fix

          There are no issues that match your filters.

          Category
          Status