Sign upLogin

AugurProject/augur-ui

View on GitHub
Star
src/modules/transactions/actions/add-transactions.js

Summary

Maintainability
F
4 days
Test Coverage

File add-transactions.js has 485 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  MARKET_CREATION,
  PUBLIC_TRADE,
  TRANSFER,
  REPORTING,
Severity: Minor
Found in src/modules/transactions/actions/add-transactions.js - About 7 hrs to fix

    Function addOpenOrderTransactions has 82 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function addOpenOrderTransactions(openOrders) {
  return (dispatch, getState) => {
    const { marketsData, transactionsData } = getState();
    // flatten open orders
    const transactions = {};
    Severity: Major
    Found in src/modules/transactions/actions/add-transactions.js - About 3 hrs to fix

      Function addTransferTransactions has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function addTransferTransactions(transfers) {
  return dispatch => {
    const transactions = {};
    each(transfers, transfer => {
      const transaction = { ...transfer };
      Severity: Major
      Found in src/modules/transactions/actions/add-transactions.js - About 2 hrs to fix

        Function addReportingTransactions has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function addReportingTransactions(reports) {
  return (dispatch, getState) => {
    const { marketsData } = getState();
    const transactions = {};
    eachOf(reports, (reports, universe) => {
        Severity: Minor
        Found in src/modules/transactions/actions/add-transactions.js - About 1 hr to fix

          Function addMarketCreationTransactions has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function addMarketCreationTransactions(marketsCreated) {
  return (dispatch, getState) => {
    const marketCreationData = {};
    const { loginAccount, marketsData } = getState();
    each(marketsCreated, marketIdOrObject => {
          Severity: Minor
          Found in src/modules/transactions/actions/add-transactions.js - About 1 hr to fix

            Function processReport has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function processReport(market, transaction) {
  const amountStaked = formatAttoRep(transaction.amountStaked, {
    decimals: 4,
    roundUp: true
  });
            Severity: Minor
            Found in src/modules/transactions/actions/add-transactions.js - About 1 hr to fix

              Function addCompleteSetsSoldLogs has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export function addCompleteSetsSoldLogs(completeSetsSoldLogs) {
  return (dispatch, getState) => {
    const { marketsData } = getState();
    const completeSetsData = {};
    each(completeSetsSoldLogs, completeSetLog => {
              Severity: Minor
              Found in src/modules/transactions/actions/add-transactions.js - About 1 hr to fix

                Function addNewMarketCreationTransactions has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                export function addNewMarketCreationTransactions(market) {
  return (dispatch, getState) => {
    const marketCreationData = {};
    const { loginAccount } = getState();
    const transaction = {
                Severity: Minor
                Found in src/modules/transactions/actions/add-transactions.js - About 1 hr to fix

                  Function getOutcome has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                  export function getOutcome(
  market,
  outcome,
  alwaysReturnYesForBinaryMarket = true
) {
                  Severity: Minor
                  Found in src/modules/transactions/actions/add-transactions.js - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function formatTransactionFillMessage has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  function formatTransactionFillMessage(txType, amount, price, numTxs, outcome) {
                  Severity: Minor
                  Found in src/modules/transactions/actions/add-transactions.js - About 35 mins to fix

                    Function getSortOrder has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function getSortOrder(type) {
  if (type === OPEN_ORDER) {
    return 10;
  }
  if (type === TRADE || type === PUBLIC_TRADE) {
                    Severity: Minor
                    Found in src/modules/transactions/actions/add-transactions.js - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid too many return statements within this function.
                    Open

                      return 1000;
                    Severity: Major
                    Found in src/modules/transactions/actions/add-transactions.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return 90;
                      Severity: Major
                      Found in src/modules/transactions/actions/add-transactions.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                            return 100;
                        Severity: Major
                        Found in src/modules/transactions/actions/add-transactions.js - About 30 mins to fix

                          TODO found
                          Open

                            // TODO: need to sort by datetime in render
                          Severity: Minor
                          Found in src/modules/transactions/actions/add-transactions.js by fixme

                          TODO found
                          Open

                          // TODO: this should be dynamic by user control
                          Severity: Minor
                          Found in src/modules/transactions/actions/add-transactions.js by fixme

                          TODO found
                          Open

                                // TODO: last order creation time will be in header, earliest activite
                          Severity: Minor
                          Found in src/modules/transactions/actions/add-transactions.js by fixme

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                if (transaction.symbol === "ether") {
        meta.value = `${
          formatAttoEth(transaction.value, { decimals: 4, roundUp: true })
            .formatted
        }`;
                          Severity: Major
                          Found in src/modules/transactions/actions/add-transactions.js and 1 other location - About 5 hrs to fix
                          src/modules/transactions/actions/add-transactions.js on lines 151..172

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 140.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                } else if (
        transaction.symbol === "REP" ||
        (transaction.market === "0x0000000000000000000000000000000000000000" &&
          transaction.eventName === "TokensTransferred")
      ) {
                          Severity: Major
                          Found in src/modules/transactions/actions/add-transactions.js and 1 other location - About 5 hrs to fix
                          src/modules/transactions/actions/add-transactions.js on lines 134..172

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 140.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      eachOf(value2, (report, index) => {
              const transaction = {
                universe,
                marketId,
                ...report,
                          Severity: Minor
                          Found in src/modules/transactions/actions/add-transactions.js and 1 other location - About 55 mins to fix
                          src/modules/transactions/actions/add-transactions.js on lines 386..398

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 54.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                    if (reportType === "initialReporter" && !isNull(value2)) {
            const transaction = {
              universe,
              marketId,
              ...value2,
                          Severity: Minor
                          Found in src/modules/transactions/actions/add-transactions.js and 1 other location - About 55 mins to fix
                          src/modules/transactions/actions/add-transactions.js on lines 399..411

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 54.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status