AuthorizeNet/sdk-java

View on GitHub

Showing 36 of 231 total issues

Method create has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @SuppressWarnings("unchecked")
    public static synchronized <T extends Serializable> T create(String xml, Class<T> classType) throws JAXBException, ParserConfigurationException, SAXException
    {
        T entity = null;
        
Severity: Minor
Found in src/main/java/net/authorize/util/XmlUtility.java - About 1 hr to fix

    Method getHttpsClient has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static CloseableHttpClient getHttpsClient() throws Exception {
            SSLContext sslcontext = getSSLContext();
            try {
                LayeredConnectionSocketFactory sslSocketFactory = new org.apache.http.conn.ssl.SSLConnectionSocketFactory(
                        sslcontext, SSLConnectionSocketFactory.STRICT_HOSTNAME_VERIFIER);
    Severity: Minor
    Found in src/main/java/net/authorize/util/HttpClient.java - About 1 hr to fix

      Method convertStreamToString has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static String convertStreamToString(InputStream is) {
      
              BOMStripperInputStream bomStripperStream = null;
              try {
                  bomStripperStream = new BOMStripperInputStream(is) ;
      Severity: Minor
      Found in src/main/java/net/authorize/util/HttpUtility.java - About 1 hr to fix

        Method initialize has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public void initialize() {
                try {
                    GsonBuilder gsonBuilder = new GsonBuilder();
                    gsonBuilder.registerTypeAdapter(SensitiveDataConfigType.class, new SensitiveTagsDeserializer());
                    gson = gsonBuilder.create();

          Method convertStreamToString has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              @Deprecated
              public static String convertStreamToString(InputStream is) {
                  BufferedReader reader = new BufferedReader(new InputStreamReader(is));
                  StringBuilder sb = new StringBuilder();
          
          Severity: Minor
          Found in src/main/java/net/authorize/util/HttpClient.java - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                                            if ( null != element.getValue() && element.getValue().getClass()==classType) {
                                                entity = (T) element.getValue();
                                            }
            Severity: Major
            Found in src/main/java/net/authorize/util/XmlUtility.java - About 45 mins to fix

              Method getHttpsClient has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  static CloseableHttpClient getHttpsClient() throws Exception {
                      SSLContext sslcontext = getSSLContext();
                      try {
                          LayeredConnectionSocketFactory sslSocketFactory = new org.apache.http.conn.ssl.SSLConnectionSocketFactory(
                                  sslcontext, SSLConnectionSocketFactory.STRICT_HOSTNAME_VERIFIER);
              Severity: Minor
              Found in src/main/java/net/authorize/util/HttpClient.java - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method convertStreamToString has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  @Deprecated
                  public static String convertStreamToString(InputStream is) {
                      BufferedReader reader = new BufferedReader(new InputStreamReader(is));
                      StringBuilder sb = new StringBuilder();
              
              Severity: Minor
              Found in src/main/java/net/authorize/util/HttpClient.java - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public void initialize() {
                      try {
                          GsonBuilder gsonBuilder = new GsonBuilder();
                          gsonBuilder.registerTypeAdapter(SensitiveDataConfigType.class, new SensitiveTagsDeserializer());
                          gson = gsonBuilder.create();
              Severity: Minor
              Found in src/main/java/net/authorize/util/SensitiveFilterPatternConverter.java - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method execute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public void execute(Environment environment) {
                      beforeExecute();
              
                      logger.debug(String.format("Executing Request:'%s'", this.getApiRequest()));
                      
              Severity: Minor
              Found in src/main/java/net/authorize/api/controller/base/ApiOperationBase.java - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method escapeStringForXml has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static String escapeStringForXml( String valueToSerialize) {
                      String retVal = valueToSerialize;
                      
                      if ( null != valueToSerialize && valueToSerialize.length() > 0) { 
                          try {
              Severity: Minor
              Found in src/main/java/net/authorize/util/XmlUtility.java - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method toString has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public String toString() {
                       StringBuilder builder = new StringBuilder();
                       builder.append("ErrorResponse: ");
                       builder.append(super.toString());
                       builder.append(", Id: ").append(this.getRefId());
              Severity: Minor
              Found in src/main/java/net/authorize/api/controller/base/ErrorResponse.java - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method descapeStringForXml has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static String descapeStringForXml(String valueToDeserialize) {
                      String retVal = valueToDeserialize;
                      
                      if ( null != valueToDeserialize && valueToDeserialize.length() > 0)
                      {
              Severity: Minor
              Found in src/main/java/net/authorize/util/XmlUtility.java - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method convertStreamToString has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static String convertStreamToString(InputStream is) {
              
                      BOMStripperInputStream bomStripperStream = null;
                      try {
                          bomStripperStream = new BOMStripperInputStream(is) ;
              Severity: Minor
              Found in src/main/java/net/authorize/util/HttpUtility.java - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method getXml has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static synchronized <T extends Serializable> String getXml(T entity) throws IOException, JAXBException
                  {
                      StringWriter sw = new StringWriter();
              
                      if ( null != entity)
              Severity: Minor
              Found in src/main/java/net/authorize/util/XmlUtility.java - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method setErrorResponse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  private void setErrorResponse(List<Message> messages, HttpResponse httpResponse) {
                      if ( null != httpResponse) {
                          messages.add(errorMessage);
                          String code = "Error";
                          String text = "Unknown Error";
              Severity: Minor
              Found in src/main/java/net/authorize/util/HttpCallTask.java - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language