Showing 27 of 50 total issues
Method ValidateServerValues has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public static string ValidateServerValues(string serverType, string name, string url, int poll, string apiToken, bool uniqueName = true)Method ValidateServerValues has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring. Open
Open
public static string ValidateServerValues(string serverType, string name, string url, int poll, string apiToken, bool uniqueName = true)
{
try
{
// check server type- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
Open
return string.Format("Invalid API Token supplied: '{0}'", apiToken);Avoid too many return statements within this method. Open
Open
return string.Format("Invalid Server URL when adding new server: '{0}'", url);Avoid too many return statements within this method. Open
Open
return string.Empty;Avoid too many return statements within this method. Open
Open
return string.Format("There was a fatal issue when validating the server information:{0}{0}{1}", Environment.NewLine, ex.Message);Avoid too many return statements within this method. Open
Open
return error;