Sign upLogin

BerniWittmann/spielplanismaning

View on GitHub
Star

Showing 181 of 353 total issues

Consider simplifying this complex logical expression.
Open

           if (index >= 0 && (data.delay || (data.delay === 0 && valBefore && valBefore !== 0)) && !_.isNaN(data.delay)) {
               vm.delays[index] = data.delay;
               recalculateDateTimePlatz()
           }
Severity: Major
Found in src/public/templates/event/spielplan/spielplan.ui.js - About 40 mins to fix

    Consider simplifying this complex logical expression.
    Open

                if (!_.isUndefined(vm.spiel.toreA) && !_.isUndefined(vm.spiel.toreB) && !_.isNull(vm.spiel.toreA) && !_.isNull(vm.spiel.toreB) && (!_.isEqual(altToreA, vm.spiel.toreA) || !_.isEqual(altToreB, vm.spiel.toreB))) {
                spiel.updateTore(vm.spiel).then(function (res) {
                    //Logger.log(res);
                    altToreA = res.toreA;
                    altToreB = res.toreB;
    Severity: Major
    Found in src/public/components/spielplan-single-spiel/spielplan-single-spiel.ui.js - About 40 mins to fix

      Function PasswordResetController has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          function PasswordResetController(auth, toastr, $stateParams, $state, isValidToken) {
      Severity: Minor
      Found in src/public/templates/shared/password-reset/password-reset.js - About 35 mins to fix

        Function PlatzController has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            function PlatzController(spiele, $stateParams, errorHandler, anzahlPlaetze, $state) {
        Severity: Minor
        Found in src/public/templates/event/platz/platz.ui.js - About 35 mins to fix

          Function getPossibleGegner has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function getPossibleGegner(gruppe, team, geradeSpielendeTeams, lastPlayingTeams, games) {
          Severity: Minor
          Found in src/routes/spielplanGenerator/helper.js - About 35 mins to fix

            Function sortTeams has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function sortTeams(teams, key, spielModel, gruppe, cb) {
            Severity: Minor
            Found in src/models/helper.js - About 35 mins to fix

              Function gruppeFindPlace has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function gruppeFindPlace(teams, spieleDerGruppe, platz, gruppe, callback) {
              Severity: Minor
              Found in src/routes/helpers.js - About 35 mins to fix

                Function LoginController has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    function LoginController(auth, $state, lockdown, $stateParams, toastr) {
                Severity: Minor
                Found in src/public/templates/shared/login/login.ui.js - About 35 mins to fix

                  Function checkCurrentEvent has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      function checkCurrentEvent(veranstaltungen, $state, AVAILABLE_STATES_WITHOUT_EVENT, toStateName, events) {
                  Severity: Minor
                  Found in src/public/app.js - About 35 mins to fix

                    Function KontaktController has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        function KontaktController(version, kontakt, env, BUG_REPORT_EMAIL, BugDialog) {
                    Severity: Minor
                    Found in src/public/templates/shared/kontakt/kontakt.ui.js - About 35 mins to fix

                      Function getEntity has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      function getEntity(model, population, notFoundMessage, res, req) {
                      Severity: Minor
                      Found in src/routes/helpers.js - About 35 mins to fix

                        Function findEntityAndPushTeam has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        function findEntityAndPushTeam(model, id, team, res, callback) {
                        Severity: Minor
                        Found in src/routes/helpers.js - About 35 mins to fix

                          Function handleQueryResponse has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          function handleQueryResponse(err, data, res, searchById, notFoundError) {
                          Severity: Minor
                          Found in src/routes/handler.js - About 35 mins to fix

                            Function createSpiel has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            function createSpiel(gruppen, rankA, rankB, jugendid, label) {
                            Severity: Minor
                            Found in src/routes/spielplanGenerator/helper.js - About 35 mins to fix

                              Function updateSpielDateTime has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  function updateSpielDateTime(singlespiel, index, spielplan, delays, cb) {
                              Severity: Minor
                              Found in src/routes/spiele.js - About 35 mins to fix

                                Function initZeiten has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    function initZeiten(spielplan, zeiten, $scope, toastr, spiele) {
                                Severity: Minor
                                Found in src/public/templates/event/verwaltung/spielplan/verwaltung.spielplan.ui.js - About 35 mins to fix

                                  Function TurnierImportController has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                      function TurnierImportController($scope, $uibModalInstance, importedJugend, gewJugend, jugend) {
                                  Severity: Minor
                                  Found in src/public/components/turnier-import-modal/turnier-import-modal.ui.js - About 35 mins to fix

                                    Function VeranstaltungenController has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                        function VeranstaltungenController(alleVeranstaltungen, auth, veranstaltungen, $state, config) {
                                    Severity: Minor
                                    Found in src/public/templates/shared/veranstaltungen/veranstaltungen.ui.js - About 35 mins to fix

                                      Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                      module.exports = function (sendgrid, env, url, disableEmails, secret) {
                                      Severity: Minor
                                      Found in src/routes/users.js - About 35 mins to fix

                                        Function deepPopulate has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                        Open

                                            function deepPopulate(model, docs, paths, options, cb) {
                                        Severity: Minor
                                        Found in src/config/mongoose-deep-populate.js - About 35 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language