Sign upLogin

BerniWittmann/spielplanismaning

View on GitHub
Star
src/routes/jugenden.js

Summary

Maintainability
D
1 day
Test Coverage

Function exports has 182 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function () {
    const logger = require('winston').loggers.get('apiJugenden');
    const express = require('express');
    const async = require('async');
    const router = express.Router();
Severity: Major
Found in src/routes/jugenden.js - About 7 hrs to fix

    Function createFilledJugend has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function createFilledJugend(req, res) {
        const beachEventID = cls.getBeachEventID();
        const clsSession = cls.getNamespace();
        return clsSession.run(function () {
            clsSession.set('beachEventID', beachEventID);
    Severity: Major
    Found in src/routes/jugenden.js - About 2 hrs to fix

      Function createBlankJugend has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function createBlankJugend(req, res) {
        const beachEventID = cls.getBeachEventID();
        const clsSession = cls.getNamespace();
        return clsSession.run(function () {
            clsSession.set('beachEventID', beachEventID);
      Severity: Minor
      Found in src/routes/jugenden.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                                    return jugend.save(function (err, jugend) {
                                if (err) return messages.Error(res, err);
                                return clsSession.run(function () {
                                    clsSession.set('beachEventID', beachEventID);
                                    return jugend.deepPopulate('teams gruppen gruppen.teams', function (err, jugend) {
        Severity: Major
        Found in src/routes/jugenden.js and 1 other location - About 2 hrs to fix
        src/routes/gruppen.js on lines 159..168

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 84.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                        return clsSession.run(function () {
                                    clsSession.set('beachEventID', beachEventID);
                                    return helpers.removeEntityBy(Jugend, '_id', req.query.id, function (err) {
                                        return handler.handleErrorAndDeleted(err, res);
                                    });
        Severity: Major
        Found in src/routes/jugenden.js and 1 other location - About 1 hr to fix
        src/routes/spiele.js on lines 134..139

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status