Sign upLogin

BerniWittmann/spielplanismaning

View on GitHub
Star
src/routes/spiele.js

Summary

Maintainability
F
3 days
Test Coverage

Function exports has 368 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (sendgrid, env, url, disableMails) {
    const logger = require('winston').loggers.get('apiSpiele');
    const express = require('express');
    const router = express.Router();
    const cls = require('../config/cls.js');
Severity: Major
Found in src/routes/spiele.js - About 1 day to fix

    File spiele.js has 371 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module.exports = function (sendgrid, env, url, disableMails) {
    const logger = require('winston').loggers.get('apiSpiele');
    const express = require('express');
    const router = express.Router();
    const cls = require('../config/cls.js');
    Severity: Minor
    Found in src/routes/spiele.js - About 4 hrs to fix

      Function notifySubscribers has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function notifySubscribers(spiel, fn, callback) {
        const beachEventID = cls.getBeachEventID();
        const clsSession = cls.getNamespace();
        return clsSession.run(function () {
            clsSession.set('beachEventID', beachEventID);
      Severity: Minor
      Found in src/routes/spiele.js - About 1 hr to fix

        Function sendNextSpielUpdates has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                                                function sendNextSpielUpdates(cb) {
                                            logger.verbose('Check if Spiel-Reminder for next Games should be sent');
                                            return clsSession.run(function () {
                                                clsSession.set('beachEventID', beachEventID);
                                                return Spiel.findOne({
        Severity: Minor
        Found in src/routes/spiele.js - About 1 hr to fix

          Function updateSpielDateTime has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              function updateSpielDateTime(singlespiel, index, spielplan, delays, cb) {
          Severity: Minor
          Found in src/routes/spiele.js - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    return clsSession.run(function () {
            clsSession.set('beachEventID', beachEventID);
            return helpers.removeEntityBy(Spiel, '_id', req.query.id, function (err) {
                return handler.handleErrorAndDeleted(err, res);
            });
            Severity: Major
            Found in src/routes/spiele.js and 1 other location - About 1 hr to fix
            src/routes/jugenden.js on lines 235..240

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 68.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                            if (!spiel.teamA || !spiel.teamA.name || !spiel.teamB || !spiel.teamB.name) {
                                    return messages.ErrorSpielNotFilled(res);
                                }
            Severity: Major
            Found in src/routes/spiele.js and 1 other location - About 1 hr to fix
            src/routes/spiele.js on lines 307..309

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                            if (!spiel.teamA || !spiel.teamA.name || !spiel.teamB || !spiel.teamB.name) {
                                    return messages.ErrorSpielNotFilled(res);
                                }
            Severity: Major
            Found in src/routes/spiele.js and 1 other location - About 1 hr to fix
            src/routes/spiele.js on lines 243..245

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status