BigKeeper/big-keeper

View on GitHub
lib/big_keeper/command/feature&hotfix.rb

Summary

Maintainability
D
2 days
Test Coverage

Method feature_and_hotfix_command has a Cognitive Complexity of 71 (exceeds 5 allowed). Consider refactoring.
Open

  def self.feature_and_hotfix_command(type)
    desc "Gitflow #{GitflowType.name(type)} operations"
    command GitflowType.command(type) do |c|
      c.desc "Start a new #{GitflowType.name(type)} with name for given modules and main project"
      c.command :start do |start|
Severity: Minor
Found in lib/big_keeper/command/feature&hotfix.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method feature_and_hotfix_command has 130 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.feature_and_hotfix_command(type)
    desc "Gitflow #{GitflowType.name(type)} operations"
    command GitflowType.command(type) do |c|
      c.desc "Start a new #{GitflowType.name(type)} with name for given modules and main project"
      c.command :start do |start|
Severity: Major
Found in lib/big_keeper/command/feature&hotfix.rb - About 5 hrs to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          c.command :finish do |finish|
            finish.action do |global_options, options, args|
              path = File.expand_path(global_options[:path])
              user = global_options[:user].gsub(/[^0-9A-Za-z]/, '').downcase
              LeanCloudLogger.instance.set_command("#{GitflowType.command(type)}/finish")
    Severity: Major
    Found in lib/big_keeper/command/feature&hotfix.rb and 3 other locations - About 55 mins to fix
    lib/big_keeper/command/feature&hotfix.rb on lines 62..69
    lib/big_keeper/command/feature&hotfix.rb on lines 89..96
    lib/big_keeper/command/feature&hotfix.rb on lines 113..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          c.command :rebase do |rebase|
            rebase.action do |global_options, options, args|
              path = File.expand_path(global_options[:path])
              user = global_options[:user].gsub(/[^0-9A-Za-z]/, '').downcase
              LeanCloudLogger.instance.set_command("#{GitflowType.command(type)}/rebase")
    Severity: Major
    Found in lib/big_keeper/command/feature&hotfix.rb and 3 other locations - About 55 mins to fix
    lib/big_keeper/command/feature&hotfix.rb on lines 62..69
    lib/big_keeper/command/feature&hotfix.rb on lines 101..108
    lib/big_keeper/command/feature&hotfix.rb on lines 113..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          c.command :publish do |publish|
            publish.action do |global_options, options, args|
              path = File.expand_path(global_options[:path])
              user = global_options[:user].gsub(/[^0-9A-Za-z]/, '').downcase
              LeanCloudLogger.instance.set_command("#{GitflowType.command(type)}/publish")
    Severity: Major
    Found in lib/big_keeper/command/feature&hotfix.rb and 3 other locations - About 55 mins to fix
    lib/big_keeper/command/feature&hotfix.rb on lines 62..69
    lib/big_keeper/command/feature&hotfix.rb on lines 89..96
    lib/big_keeper/command/feature&hotfix.rb on lines 101..108

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          c.command :pull do |pull|
            pull.action do |global_options, options, args|
              path = File.expand_path(global_options[:path])
              user = global_options[:user].gsub(/[^0-9A-Za-z]/, '').downcase
              LeanCloudLogger.instance.set_command("#{GitflowType.command(type)}/pull")
    Severity: Major
    Found in lib/big_keeper/command/feature&hotfix.rb and 3 other locations - About 55 mins to fix
    lib/big_keeper/command/feature&hotfix.rb on lines 89..96
    lib/big_keeper/command/feature&hotfix.rb on lines 101..108
    lib/big_keeper/command/feature&hotfix.rb on lines 113..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status