Sign upLogin

Billmike/More-Recipes

View on GitHub
Star
server/controllers/recipes.js

Summary

Maintainability
A
1 hr
Test Coverage

Function searchRecipes has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Invalid

  static searchRecipes(req, res) {
    const { search } = req.query;
    let offset = 0;
    const limit = 6;
    let singlePage;
Severity: Major
Found in server/controllers/recipes.js - About 2 hrs to fix

    File recipes.js has 257 lines of code (exceeds 250 allowed). Consider refactoring.
    Invalid

    import Sequelize from 'sequelize';
import db from '../models/index';
import errorMessage from '../errorHandler/errorMessage';

const { Op } = Sequelize;
    Severity: Minor
    Found in server/controllers/recipes.js - About 2 hrs to fix

      Function addRecipe has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Invalid

        static addRecipe(req, res) {
    const {
      name,
      description,
      imageUrl,
      Severity: Minor
      Found in server/controllers/recipes.js - About 1 hr to fix

        Function getRecipes has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Invalid

          static getRecipes(req, res) {
    let offset = 0;
    const limit = 6;
    let singlePage;
    let pages;
        Severity: Minor
        Found in server/controllers/recipes.js - About 1 hr to fix

          Function popularRecipes has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Invalid

            static popularRecipes(req, res) {
    return recipes
      .findAll({
        include: [
          {
          Severity: Minor
          Found in server/controllers/recipes.js - About 1 hr to fix

            Function modifyRecipe has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              static modifyRecipe(req, res) {
    return recipes
      .findById(req.params.recipeId)
      .then((recipe) => {
        if (!recipe) {
            Severity: Minor
            Found in server/controllers/recipes.js - About 1 hr to fix

              Unexpected string concatenation of literals.
              Open

                            'You cannot delete this recipe' + ' as it does not belong to you.'
              Severity: Minor
              Found in server/controllers/recipes.js by eslint

              Disallow unnecessary concatenation of strings (no-useless-concat)

              It's unnecessary to concatenate two strings together, such as:

              var foo = "a" + "b";

              This code is likely the result of refactoring where a variable was removed from the concatenation (such as "a" + b + "b"). In such a case, the concatenation isn't important and the code can be rewritten as:

              var foo = "ab";

              Rule Details

              This rule aims to flag the concatenation of 2 literals when they could be combined into a single literal. Literals can be strings or template literals.

              Examples of incorrect code for this rule:

              /*eslint no-useless-concat: "error"*/
/*eslint-env es6*/

// these are the same as "10"
var a = `some` + `string`;
var a = '1' + '0';
var a = '1' + `0`;
var a = `1` + '0';
var a = `1` + `0`;

              Examples of correct code for this rule:

              /*eslint no-useless-concat: "error"*/

// when a non string is included
var c = a + b;
var c = '1' + a;
var a = 1 + '1';
var c = 1 - 2;
// when the string concatenation is multiline
var c = "foo" +
    "bar";

              When Not To Use It

              If you don't want to be notified about unnecessary string concatenation, you can safely disable this rule. Source: http://eslint.org/docs/rules/

              Identical blocks of code found in 2 locations. Consider refactoring.
              Invalid

                      where: {
          [Op.or]: {
            name: {
              [Op.iLike]: `%${search}`
            },
              Severity: Major
              Found in server/controllers/recipes.js and 1 other location - About 1 hr to fix
              server/controllers/recipes.js on lines 252..261

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 64.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Invalid

                          where: {
              [Op.or]: {
                name: {
                  [Op.iLike]: `%${search}`
                },
              Severity: Major
              Found in server/controllers/recipes.js and 1 other location - About 1 hr to fix
              server/controllers/recipes.js on lines 224..233

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 64.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status