Sign upLogin

BitolaHacklab/Hanako

View on GitHub
Star

Showing 2 of 6 total issues

Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, id, world_id, state_hash, _type, value=None, timestamp=None):
Severity: Minor
Found in hanako/model/world.py - About 45 mins to fix

    Function _calculate_world_state has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

        def _calculate_world_state(self, world_id, at_hash):
        state = self.world_repo.get_last_before(world_id, at_hash)

        while True:
            actions = self.action_repo.get_after(at_hash)
    Severity: Minor
    Found in hanako/state/api.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language