Sign upLogin

BookStackApp/BookStack

View on GitHub
Star
resources/js/wysiwyg/utils/lists.ts
c84d9994

Summary

Maintainability
C
7 hrs
Test Coverage

Function $setInsetForSelection has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

export function $setInsetForSelection(editor: LexicalEditor, change: number): void {
    const selection = $getSelection();
    const selectionBounds = selection?.getStartEndPoints();
    const listItemsInSelection = getListItemsForSelection(selection);
    const isListSelection = listItemsInSelection.length > 0 && !listItemsInSelection.includes(null);
Severity: Minor
Found in resources/js/wysiwyg/utils/lists.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function $setInsetForSelection has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function $setInsetForSelection(editor: LexicalEditor, change: number): void {
    const selection = $getSelection();
    const selectionBounds = selection?.getStartEndPoints();
    const listItemsInSelection = getListItemsForSelection(selection);
    const isListSelection = listItemsInSelection.length > 0 && !listItemsInSelection.includes(null);
Severity: Minor
Found in resources/js/wysiwyg/utils/lists.ts - About 1 hr to fix

    Function $nestListItem has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function $nestListItem(node: ListItemNode): ListItemNode {
    const list = node.getParent();
    if (!$isListNode(list)) {
        return node;
    }
    Severity: Minor
    Found in resources/js/wysiwyg/utils/lists.ts - About 1 hr to fix

      Function getListItemsForSelection has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      function getListItemsForSelection(selection: BaseSelection|null): (ListItemNode|null)[] {
    const nodes = selection?.getNodes() || [];
    const listItemNodes = [];

    outer: for (const node of nodes) {
      Severity: Minor
      Found in resources/js/wysiwyg/utils/lists.ts - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function $nestListItem has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export function $nestListItem(node: ListItemNode): ListItemNode {
    const list = node.getParent();
    if (!$isListNode(list)) {
        return node;
    }
      Severity: Minor
      Found in resources/js/wysiwyg/utils/lists.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status