Sign upLogin

Bottaajat/cultura

View on GitHub
Star
public/js/crossword.task.js

Summary

Maintainability
F
3 days
Test Coverage

Function init has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

function init (answers, clues, positions, orientations) {
    
    var limits = grid_size(positions, answers, orientations);
    var grid = grid_create(limits[0], limits[1], limits[2], limits[3]);
    var filled_grid = grid_fill(grid, positions, answers, orientations, limits[0]);
Severity: Minor
Found in public/js/crossword.task.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function init has 84 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function init (answers, clues, positions, orientations) {
    
    var limits = grid_size(positions, answers, orientations);
    var grid = grid_create(limits[0], limits[1], limits[2], limits[3]);
    var filled_grid = grid_fill(grid, positions, answers, orientations, limits[0]);
Severity: Major
Found in public/js/crossword.task.js - About 3 hrs to fix

    Function grid_fill has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    function grid_fill(grid, positions, answers, orientations, x_min) {
    
    for (i = 0; i < positions.length; i++) {
    
        var position_start = positions[i].split('.');
    Severity: Minor
    Found in public/js/crossword.task.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function grid_size has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    function grid_size (positions, answers, orientations) {
    var x_min = 0;
    var x_max = 0;
    var y_min = 0;
    var y_max = 0;
    Severity: Minor
    Found in public/js/crossword.task.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function grid_size has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function grid_size (positions, answers, orientations) {
    var x_min = 0;
    var x_max = 0;
    var y_min = 0;
    var y_max = 0;
    Severity: Minor
    Found in public/js/crossword.task.js - About 1 hr to fix

      Function check has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function check () {
    var correct = true;
    var current_word = '';
    var last_word = '';
    var whole_word = [];
      Severity: Minor
      Found in public/js/crossword.task.js - About 1 hr to fix

        Function grid_fill has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function grid_fill(grid, positions, answers, orientations, x_min) {
    
    for (i = 0; i < positions.length; i++) {
    
        var position_start = positions[i].split('.');
        Severity: Minor
        Found in public/js/crossword.task.js - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                              if (isMobile == true) $(row_add).append('<td><input type = "text" class = "square letter" id = "'+x+','+y+'" word = "'+y+'" letter = "'+row[x]+'"></td>');
                    else $(row_add).append('<td><input type = "text" class = "keyboard square letter" id = "'+x+','+y+'" word = "'+y+'" letter = "'+row[x]+'"></td>');
          Severity: Major
          Found in public/js/crossword.task.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if (isMobile == true) $(row_add).append('<td><input type = "text" class = "square vertical letter" id = "'+x+','+y+'" word = "'+y+'" letter = "'+row[x]+'"></td>');
                    else $(row_add).append('<td><input type = "text" class = "keyboard square vertical letter" id = "'+x+','+y+'" word = "'+y+'" letter = "'+row[x]+'"></td>');
            Severity: Major
            Found in public/js/crossword.task.js - About 45 mins to fix

              Function grid_fill has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function grid_fill(grid, positions, answers, orientations, x_min) {
              Severity: Minor
              Found in public/js/crossword.task.js - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                if (vertical_x == x) {
                    if (isMobile == true) $(row_add).append('<td><input type = "text" class = "square vertical letter" id = "'+x+','+y+'" word = "'+y+'" letter = "'+row[x]+'"></td>');
                    else $(row_add).append('<td><input type = "text" class = "keyboard square vertical letter" id = "'+x+','+y+'" word = "'+y+'" letter = "'+row[x]+'"></td>');
                }
                Severity: Major
                Found in public/js/crossword.task.js and 1 other location - About 3 hrs to fix
                public/js/crossword.task.js on lines 42..45

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 114.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                else {
                    if (isMobile == true) $(row_add).append('<td><input type = "text" class = "square letter" id = "'+x+','+y+'" word = "'+y+'" letter = "'+row[x]+'"></td>');
                    else $(row_add).append('<td><input type = "text" class = "keyboard square letter" id = "'+x+','+y+'" word = "'+y+'" letter = "'+row[x]+'"></td>');
                }
                Severity: Major
                Found in public/js/crossword.task.js and 1 other location - About 3 hrs to fix
                public/js/crossword.task.js on lines 38..41

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 114.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status