Sign upLogin

BrandyMint/iframely

View on GitHub
Star

Showing 2 of 4 total issues

Method build has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def self.build json
      if json.is_a? Hash
        if json.include?('error')
          Iframely::ErrorModel.new error: json['error'], json: json
        else
Severity: Minor
Found in lib/iframely/model.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize api_key: nil, cache: nil, cache_options: {}, iframely_url: IFRAMELY_API_URL, oembed_url: OEMBED_API_URL
      @iframely_url  = iframely_url or raise "No iframely_url specified"
      @oembed_url    = oembed_url or raise "No oembed_url specified"
      @api_key       = api_key      or raise "No api_key specified"
      @cache         = cache
Severity: Minor
Found in lib/iframely/requester.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language