BuddhaNexus/buddhanexus-frontend

View on GitHub
src/views/data/data-view-filters-container.js

Summary

Maintainability
D
2 days
Test Coverage

File data-view-filters-container.js has 286 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { customElement, html, css, LitElement, property } from 'lit-element';

import 'multiselect-combo-box/theme/material/multiselect-combo-box';

import '../utility/LoadingSpinner';
Severity: Minor
Found in src/views/data/data-view-filters-container.js - About 2 hrs to fix

    Function render has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render() {
        const shouldShowMultiLingFilters =
          this.viewMode !== DATA_VIEW_MODES.MULTILING;
        //prettier-ignore
        return html`
    Severity: Major
    Found in src/views/data/data-view-filters-container.js - About 2 hrs to fix

      DataViewFiltersContainer has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      @customElement('data-view-filters-container')
      export class DataViewFiltersContainer extends LitElement {
        // Filter sliders:
        @property({ type: String }) viewMode;
        @property({ type: String }) fileName;
      Severity: Minor
      Found in src/views/data/data-view-filters-container.js - About 2 hrs to fix

        Function renderFilesCollectionFilters has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          renderFilesCollectionFilters() {
            const loading =
              this.filterCategoriesDataLoading ||
              this.filterFilesDataLoading ||
              this.filterCategoriesDataLoading ||
        Severity: Major
        Found in src/views/data/data-view-filters-container.js - About 2 hrs to fix

          Function renderFilesCollectionFilters has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            renderFilesCollectionFilters() {
              const loading =
                this.filterCategoriesDataLoading ||
                this.filterFilesDataLoading ||
                this.filterCategoriesDataLoading ||
          Severity: Minor
          Found in src/views/data/data-view-filters-container.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            handleCategoriesExcludeComboBoxChanged(e) {
              let CategoriesExclude = e.detail.value.map(item => item.category);
              this.selectedCategoriesExclude = CategoriesExclude.map(item => `!${item}`);
              this.updateFilters();
            }
          Severity: Major
          Found in src/views/data/data-view-filters-container.js and 1 other location - About 2 hrs to fix
          src/views/data/data-view-filters-container.js on lines 124..128

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 77.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            handleFilesExcludeComboBoxChanged = e => {
              let filenamesExclude = e.detail.value.map(item => item.filename);
              this.selectedFilenamesExclude = filenamesExclude.map(item => `!${item}`);
              this.updateFilters();
            };
          Severity: Major
          Found in src/views/data/data-view-filters-container.js and 1 other location - About 2 hrs to fix
          src/views/data/data-view-filters-container.js on lines 130..134

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 77.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              return html`
                ${shouldShowMultiLingFilters
                  ? html`
                    <data-view-filters-multilingual
                      style="display: ${
          Severity: Major
          Found in src/views/data/data-view-filters-container.js and 1 other location - About 1 hr to fix
          src/views/textview/text-view-table.js on lines 101..129

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            handleTargetComboBoxChanged(e) {
              this.selectedCollections = e.detail.value.map(item => item.collectionkey);
              this.updateTargetFilters();
            }
          Severity: Minor
          Found in src/views/data/data-view-filters-container.js and 1 other location - About 55 mins to fix
          src/views/data/data-view-filters-container.js on lines 119..122

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            handleCategoriesComboBoxChanged(e) {
              this.selectedCategories = e.detail.value.map(item => item.category);
              this.updateFilters();
            }
          Severity: Minor
          Found in src/views/data/data-view-filters-container.js and 1 other location - About 55 mins to fix
          src/views/data/data-view-filters-container.js on lines 136..139

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                this.viewMode !== DATA_VIEW_MODES.GRAPH &&
                this.viewMode !== DATA_VIEW_MODES.MULTILANG &&
                this.viewMode !== DATA_VIEW_MODES.ENGLISH
          Severity: Minor
          Found in src/views/data/data-view-filters-container.js and 1 other location - About 30 mins to fix
          src/views/data/data-view-header-fields.js on lines 199..201

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status