BuddhaNexus/buddhanexus-frontend

View on GitHub
src/views/utility/formatted-segment.js

Summary

Maintainability
D
1 day
Test Coverage

File formatted-segment.js has 287 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { customElement, html, LitElement, property, css } from 'lit-element';

import { getDisplayName } from '../../api/actions';
import { getLanguageFromFilename } from './views-common';
import { segmentArrayToString } from './preprocessing';
Severity: Minor
Found in src/views/utility/formatted-segment.js - About 2 hrs to fix

    Function getLinkForSegmentNumbers has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      getLinkForSegmentNumbers(language, segmentnr) {
        // prettier-ignore
        const dhpVerses = [1,21,33,44,60,76,90,100,116,129,146,157,167,179,197,
                            209,221,235,256,273,290,306,320,334,360,383,424]
        let linkText = '';
    Severity: Minor
    Found in src/views/utility/formatted-segment.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getLinkForSegmentNumbers has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      getLinkForSegmentNumbers(language, segmentnr) {
        // prettier-ignore
        const dhpVerses = [1,21,33,44,60,76,90,100,116,129,146,157,167,179,197,
                            209,221,235,256,273,290,306,320,334,360,383,424]
        let linkText = '';
    Severity: Minor
    Found in src/views/utility/formatted-segment.js - About 1 hr to fix

      Function getExternalLinkName has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        getExternalLinkName(language, externalLink) {
          if (!externalLink) {
            return;
          }
          let linkName = '';
      Severity: Minor
      Found in src/views/utility/formatted-segment.js - About 1 hr to fix

        Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          render() {
            if (this.fetchLoading || !this.displayName) {
              // prettier-ignore
              return html`<span class="formatted-segment" title="${this.filename}">${this.filename}:${this.number}</span>`
            }
        Severity: Minor
        Found in src/views/utility/formatted-segment.js - About 1 hr to fix

          Function parseDisplayData has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            parseDisplayData(displayData, segmentnrString) {
              this.displayName = displayData ? displayData[0] : '';
              if (!this.shouldNotShowExtLink) {
                if (
                  this.lang === LANGUAGE_CODES.SANSKRIT ||
          Severity: Minor
          Found in src/views/utility/formatted-segment.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getIcon has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            getIcon(par_lang) {
              if (!this.logo) {
                return;
              }
              let title;
          Severity: Minor
          Found in src/views/utility/formatted-segment.js - About 1 hr to fix

            Function getExternalLinkName has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              getExternalLinkName(language, externalLink) {
                if (!externalLink) {
                  return;
                }
                let linkName = '';
            Severity: Minor
            Found in src/views/utility/formatted-segment.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                switch (par_lang) {
                  case LANGUAGE_CODES.TIBETAN:
                    title = LANGUAGE_NAMES.TIBETAN;
                    break;
                  case LANGUAGE_CODES.SANSKRIT:
            Severity: Major
            Found in src/views/utility/formatted-segment.js and 1 other location - About 2 hrs to fix
            src/views/menus/navigation-menu.js on lines 147..162

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status