Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/batches/newbatch/edit.js

Summary

Maintainability
F
6 days
Test Coverage

Function batchEdit has 420 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var batchEdit = (function ($) {
    var mod = {};

    var alerthi = function() {
        alert('hi');
Severity: Major
Found in fannie/batches/newbatch/edit.js - About 2 days to fix

    File edit.js has 422 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    var batchEdit = (function ($) {
    var mod = {};

    var alerthi = function() {
        alert('hi');
    Severity: Minor
    Found in fannie/batches/newbatch/edit.js - About 6 hrs to fix

      Function batchEdit has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
      Open

      var batchEdit = (function ($) {
    var mod = {};

    var alerthi = function() {
        alert('hi');
      Severity: Minor
      Found in fannie/batches/newbatch/edit.js - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function editBatchDate has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          mod.editBatchDate = function(olddate, action)
    {
        //alert(olddate);
        var start = $('#startDate').val();
        var end = $('#endDate').val();
      Severity: Minor
      Found in fannie/batches/newbatch/edit.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            mod.swapDiscountToQualifier = function(elem, upc)
    {
        var tr = $(elem).closest('tr');
        $.ajax({
            type: 'post',
        Severity: Major
        Found in fannie/batches/newbatch/edit.js and 1 other location - About 7 hrs to fix
        fannie/batches/newbatch/edit.js on lines 269..285

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 183.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            mod.swapQualifierToDiscount = function(elem, upc)
    {
        var tr = $(elem).closest('tr');
        $.ajax({
            type: 'post',
        Severity: Major
        Found in fannie/batches/newbatch/edit.js and 1 other location - About 7 hrs to fix
        fannie/batches/newbatch/edit.js on lines 251..267

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 183.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            mod.saveNotes = function(batchID) {
        var dstr = $('#batchNotes').serialize() + '&noteID=' + batchID;
        $.ajax({
            type: 'post',
            data: dstr
        Severity: Major
        Found in fannie/batches/newbatch/edit.js and 1 other location - About 2 hrs to fix
        fannie/batches/newbatch/edit.js on lines 333..340

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 78.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            mod.updatePartial = function(batchID) {
        var dstr = $('.partialBatch').serialize() + '&partialID=' + batchID;
        $.ajax({
            type: 'post',
            data: dstr
        Severity: Major
        Found in fannie/batches/newbatch/edit.js and 1 other location - About 2 hrs to fix
        fannie/batches/newbatch/edit.js on lines 342..349

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 78.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                var stopBatch = (curDate.getTime() > checkEndDate.getTime() || curDate.getTime() < checkStartDate) ? true : false;
        Severity: Minor
        Found in fannie/batches/newbatch/edit.js and 1 other location - About 35 mins to fix
        fannie/batches/newbatch/edit.js on lines 433..433

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                var startBatch = (curDate.getTime() <= checkEndDate.getTime() && curDate.getTime() >= checkStartDate) ? true : false;
        Severity: Minor
        Found in fannie/batches/newbatch/edit.js and 1 other location - About 35 mins to fix
        fannie/batches/newbatch/edit.js on lines 432..432

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status