Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/item/images/nutrifacts.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function nutriFacts has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var nutriFacts = (function($) {
    var mod = {};

    var setByName = function(name, val) {
        if (typeof val !== 'undefined') {
Severity: Minor
Found in fannie/item/images/nutrifacts.js - About 1 hr to fix

    Function doLookup has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        mod.doLookup = function(e) {

        $('input[type=text]').each(function(){
            let name = $(this).attr('name');
            if (name != 'upc')
    Severity: Minor
    Found in fannie/item/images/nutrifacts.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      $('input.dv-in')
                    .filter(function(){console.log(this.value);return this.value==='';})
                    .first().val(resp.opts[i].percentDV);
      Severity: Major
      Found in fannie/item/images/nutrifacts.js and 1 other location - About 1 hr to fix
      fannie/item/images/nutrifacts.js on lines 40..42

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      $('input.nutrient-in')
                    .filter(function(){console.log(this.value);return this.value==='';})
                    .first().val(resp.opts[i].name);
      Severity: Major
      Found in fannie/item/images/nutrifacts.js and 1 other location - About 1 hr to fix
      fannie/item/images/nutrifacts.js on lines 43..45

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status