Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/item/marginTool.js

Summary

Maintainability
D
2 days
Test Coverage

Function marginTool has 87 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var marginTool = (function($) {
    var mod = {};

    mod.createBatch = function() {
        var cArray = Array();
Severity: Major
Found in fannie/item/marginTool.js - About 3 hrs to fix

    Function reCalc has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        mod.reCalc = function(upc, price, cost, deptID, superID) {
        var newprice = Number(price);
        if (cost == 0 || isNaN(newprice)) {
            return false;
        }
    Severity: Minor
    Found in fannie/item/marginTool.js - About 1 hr to fix

      Function marginTool has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      var marginTool = (function($) {
    var mod = {};

    mod.createBatch = function() {
        var cArray = Array();
      Severity: Minor
      Found in fannie/item/marginTool.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createBatch has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          mod.createBatch = function() {
        var cArray = Array();
        var pArray = Array();
        var uArray = Array();
        $('.itemrow').each(function(){
      Severity: Minor
      Found in fannie/item/marginTool.js - About 1 hr to fix

        Function reCalc has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            mod.reCalc = function(upc, price, cost, deptID, superID) {
        Severity: Minor
        Found in fannie/item/marginTool.js - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $('.super'+superID).each(function(){
            pArray.push($(this).find('.newprice').val());
            uArray.push($(this).find('.itemupc').val());
        });
          Severity: Major
          Found in fannie/item/marginTool.js and 1 other location - About 2 hrs to fix
          fannie/item/marginTool.js on lines 69..72

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 84.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $('.dept'+deptID).each(function(){
            pArray.push($(this).find('.newprice').val());
            uArray.push($(this).find('.itemupc').val());
        });
          Severity: Major
          Found in fannie/item/marginTool.js and 1 other location - About 2 hrs to fix
          fannie/item/marginTool.js on lines 88..91

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 84.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $.ajax({
            url: 'MarginToolFromSearch.php',
            type: 'post',
            data: 'upcs='+upcs+'&superID='+superID+'&newprices='+prices
        }).done(function(resp) {
          Severity: Major
          Found in fannie/item/marginTool.js and 1 other location - About 2 hrs to fix
          fannie/item/marginTool.js on lines 76..82

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 83.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $.ajax({
            url: 'MarginToolFromSearch.php',
            type: 'post',
            data: 'upcs='+upcs+'&deptID='+deptID+'&newprices='+prices
        }).done(function(resp) {
          Severity: Major
          Found in fannie/item/marginTool.js and 1 other location - About 2 hrs to fix
          fannie/item/marginTool.js on lines 95..101

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 83.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (curprice == newprice) {
            $('#row'+upc).css('font-weight', 'normal');
            $('#row'+upc+' td').each(function() {
                $(this).css('background-color', '');
            });
          Severity: Major
          Found in fannie/item/marginTool.js and 1 other location - About 1 hr to fix
          fannie/item/marginTool.js on lines 54..59

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  } else {
            $('#row'+upc).css('font-weight', 'bold');
            $('#row'+upc+' td').each(function() {
                $(this).css('background-color', '#ffc');
            });
          Severity: Major
          Found in fannie/item/marginTool.js and 1 other location - About 1 hr to fix
          fannie/item/marginTool.js on lines 49..54

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status