Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/item/productList.js

Summary

Maintainability
D
1 day
Test Coverage

Function productList has 157 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var productList = (function($) {
    var mod = {};

    var drawCheckbox = function(elem, cell, field) {
        var fs = elem.find('.' + cell + ':first').html();
Severity: Major
Found in fannie/item/productList.js - About 6 hrs to fix

    Function productList has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

    var productList = (function($) {
    var mod = {};

    var drawCheckbox = function(elem, cell, field) {
        var fs = elem.find('.' + cell + ':first').html();
    Severity: Minor
    Found in fannie/item/productList.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function save has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        mod.save = function(elem) {
        var upc = elem.find('.hidden_upc:first').val();
        var store_id = elem.find('.hidden_store_id:first').val();
        var dstr = 'ajax=save';
    Severity: Minor
    Found in fannie/item/productList.js - About 1 hr to fix

      Function edit has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          mod.edit = function(elem) {
        var text = [{name:'brand',size:8}, {name:'desc',size:10}, {name:'cost',size:4}, {name:'price',size:4}];
        text.forEach(function(i) {
            drawTextBox(elem, 'td_'+i.name, 'in_'+i.name, i.size);
        });
      Severity: Minor
      Found in fannie/item/productList.js - About 1 hr to fix

        Function drawKeyValSelect has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            var drawKeyValSelect = function(elem, cell, field, obj, onChange) {
        Severity: Minor
        Found in fannie/item/productList.js - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $.ajax({
            url: 'ProductListPage.php',
            data: 'ajax=deleteCheck&upc='+upc+'&desc='+desc,
            dataType: 'json',
            type: 'post'
          Severity: Minor
          Found in fannie/item/productList.js and 1 other location - About 35 mins to fix
          fannie/item/vendors/index.js on lines 39..49

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status