Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/CoopCred/programs/CalendarControl.js

Summary

Maintainability
F
4 days
Test Coverage

Function CalendarControl has a Cognitive Complexity of 79 (exceeds 5 allowed). Consider refactoring.
Open

function CalendarControl() {

  var calendarId = 'CalendarControl';
  var currentYear = 0;
  var currentMonth = 0;
Severity: Minor
Found in fannie/modules/plugins2.0/CoopCred/programs/CalendarControl.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function CalendarControl has 187 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function CalendarControl() {

  var calendarId = 'CalendarControl';
  var currentYear = 0;
  var currentMonth = 0;
Severity: Major
Found in fannie/modules/plugins2.0/CoopCred/programs/CalendarControl.js - About 7 hrs to fix

    File CalendarControl.js has 269 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    function positionInfo(object) {

  var p_elm = object;

  this.getElementLeft = getElementLeft;
    Severity: Minor
    Found in fannie/modules/plugins2.0/CoopCred/programs/CalendarControl.js - About 2 hrs to fix

      Function positionInfo has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function positionInfo(object) {

  var p_elm = object;

  this.getElementLeft = getElementLeft;
      Severity: Major
      Found in fannie/modules/plugins2.0/CoopCred/programs/CalendarControl.js - About 2 hrs to fix

        Function positionInfo has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

        function positionInfo(object) {

  var p_elm = object;

  this.getElementLeft = getElementLeft;
        Severity: Minor
        Found in fannie/modules/plugins2.0/CoopCred/programs/CalendarControl.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function calendarDrawTable has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function calendarDrawTable() {

    var dayOfMonth = 1;
    var validDay = 0;
    var startDayOfWeek = getDayOfWeek(currentYear, currentMonth, dayOfMonth);
        Severity: Minor
        Found in fannie/modules/plugins2.0/CoopCred/programs/CalendarControl.js - About 1 hr to fix

          Function show has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function show(field) {
  
    // If the calendar is visible and associated with
    // this field do not do anything.
    if (dateField == field) {
          Severity: Minor
          Found in fannie/modules/plugins2.0/CoopCred/programs/CalendarControl.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              function getElementLeft() {
    var x = 0;
    var elm;
    if(typeof(p_elm) == "object"){
      elm = p_elm;
            Severity: Major
            Found in fannie/modules/plugins2.0/CoopCred/programs/CalendarControl.js and 1 other location - About 3 hrs to fix
            fannie/modules/plugins2.0/CoopCred/programs/CalendarControl.js on lines 38..51

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 99.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              function getElementTop() {
    var y = 0;
    var elm;
    if(typeof(p_elm) == "object"){
      elm = p_elm;
            Severity: Major
            Found in fannie/modules/plugins2.0/CoopCred/programs/CalendarControl.js and 1 other location - About 3 hrs to fix
            fannie/modules/plugins2.0/CoopCred/programs/CalendarControl.js on lines 6..19

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 99.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              function getElementHeight(){
    var elm;
    if(typeof(p_elm) == "object"){
      elm = p_elm;
    } else {
            Severity: Major
            Found in fannie/modules/plugins2.0/CoopCred/programs/CalendarControl.js and 1 other location - About 1 hr to fix
            fannie/modules/plugins2.0/CoopCred/programs/CalendarControl.js on lines 22..30

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              function getElementWidth(){
    var elm;
    if(typeof(p_elm) == "object"){
      elm = p_elm;
    } else {
            Severity: Major
            Found in fannie/modules/plugins2.0/CoopCred/programs/CalendarControl.js and 1 other location - About 1 hr to fix
            fannie/modules/plugins2.0/CoopCred/programs/CalendarControl.js on lines 54..62

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status