CORE-POS/IS4C

View on GitHub
fannie/modules/plugins2.0/CoreWarehouse/reports/mk.js

Summary

Maintainability
C
1 day
Test Coverage

Function mk has 91 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var mk = (function ($) {
    var mod = {};
    
    var lineGraph = function(elem, name, labels, data1, data2) {
        var ctx = document.getElementById(elem);
Severity: Major
Found in fannie/modules/plugins2.0/CoreWarehouse/reports/mk.js - About 3 hrs to fix

    Function lineGraph has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var lineGraph = function(elem, name, labels, data1, data2) {
            var ctx = document.getElementById(elem);
            var chart = new Chart(ctx, {
                type: 'line',
                data: {
    Severity: Minor
    Found in fannie/modules/plugins2.0/CoreWarehouse/reports/mk.js - About 1 hr to fix

      Function barGraph has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          var barGraph = function(labels, hillside, denfeld) {
              var ctx = document.getElementById('barGraph');
              var sets = [
                  {
                      label: "Denfeld Dollar Growth",
      Severity: Minor
      Found in fannie/modules/plugins2.0/CoreWarehouse/reports/mk.js - About 1 hr to fix

        Function lineGraph has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            var lineGraph = function(elem, name, labels, data1, data2) {
        Severity: Minor
        Found in fannie/modules/plugins2.0/CoreWarehouse/reports/mk.js - About 35 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      options: {
                          scales: {
                              yAxes: [{
                                  ticks: {
                                      callback: function(val, i, vals) {
          Severity: Major
          Found in fannie/modules/plugins2.0/CoreWarehouse/reports/mk.js and 1 other location - About 1 hr to fix
          fannie/modules/plugins2.0/CoreWarehouse/reports/mk.js on lines 34..44

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      options: {
                          scales: {
                              yAxes: [{
                                  ticks: {
                                      callback: function(val, i, vals) {
          Severity: Major
          Found in fannie/modules/plugins2.0/CoreWarehouse/reports/mk.js and 1 other location - About 1 hr to fix
          fannie/modules/plugins2.0/CoreWarehouse/reports/mk.js on lines 74..84

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              {
                                  data: data1, 
                                  fill: false,
                                  lineTension: 0,
                                  label: name + ' Sales TY',
          Severity: Minor
          Found in fannie/modules/plugins2.0/CoreWarehouse/reports/mk.js and 1 other location - About 35 mins to fix
          fannie/modules/plugins2.0/CoreWarehouse/reports/mk.js on lines 22..31

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              { 
                                  data: data2, 
                                  fill: false,
                                  lineTension: 0,
                                  label: name + ' Sales LY',
          Severity: Minor
          Found in fannie/modules/plugins2.0/CoreWarehouse/reports/mk.js and 1 other location - About 35 mins to fix
          fannie/modules/plugins2.0/CoreWarehouse/reports/mk.js on lines 12..21

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status