Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
fannie/modules/plugins2.0/DeliInventory/di.js

Summary

Maintainability
F
1 wk
Test Coverage

Function di has 262 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var di = (function ($) {
    var mod = {};

    var openInput = false;
    var openVendor = false;
Severity: Major
Found in fannie/modules/plugins2.0/DeliInventory/di.js - About 1 day to fix

    Function di has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
    Open

    var di = (function ($) {
    var mod = {};

    var openInput = false;
    var openVendor = false;
    Severity: Minor
    Found in fannie/modules/plugins2.0/DeliInventory/di.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File di.js has 264 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    var di = (function ($) {
    var mod = {};

    var openInput = false;
    var openVendor = false;
    Severity: Minor
    Found in fannie/modules/plugins2.0/DeliInventory/di.js - About 2 hrs to fix

      Function keyNav has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function keyNav(ev) {
        switch (ev.which) {
            case 9:
                ev.preventDefault();
                if (ev.shiftKey) {
      Severity: Minor
      Found in fannie/modules/plugins2.0/DeliInventory/di.js - About 1 hr to fix

        Function initRows has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            mod.initRows = function() {
        $('td.editable').click(function() {
            mod.editRow(this);
        });
        $('td.vendor').click(function() {
        Severity: Minor
        Found in fannie/modules/plugins2.0/DeliInventory/di.js - About 1 hr to fix

          Function categorySave has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function categorySave(elem) {
        var itemID = $(elem).closest('tr').attr('data-item-id');
        var catID = $(elem).find('select').val();
        var catName = $(elem).find('select option:selected').text();
        var dataStr = 'id=' + itemID + '&catID=' + catID + '&category=' + encodeURIComponent(catName);;
          Severity: Minor
          Found in fannie/modules/plugins2.0/DeliInventory/di.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                function categorySelect(elem) {
        if (openCategory == elem) {
            return;
        }
        if (openInput) {
            Severity: Major
            Found in fannie/modules/plugins2.0/DeliInventory/di.js and 1 other location - About 1 day to fix
            fannie/modules/plugins2.0/DeliInventory/di.js on lines 22..46

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 240.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                function vendorSelect(elem) {
        if (openVendor == elem) {
            return;
        }
        if (openInput) {
            Severity: Major
            Found in fannie/modules/plugins2.0/DeliInventory/di.js and 1 other location - About 1 day to fix
            fannie/modules/plugins2.0/DeliInventory/di.js on lines 63..87

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 240.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                mod.hideSourcing = function() {
        $('.upc').hide();
        $('.sku').hide();
        $('.vendor').hide();
        $('.trash').hide();
            Severity: Major
            Found in fannie/modules/plugins2.0/DeliInventory/di.js and 1 other location - About 3 hrs to fix
            fannie/modules/plugins2.0/DeliInventory/di.js on lines 244..251

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 114.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                mod.showSourcing = function() {
        $('.upc').show();
        $('.sku').show();
        $('.vendor').show();
        $('.trash').show();
            Severity: Major
            Found in fannie/modules/plugins2.0/DeliInventory/di.js and 1 other location - About 3 hrs to fix
            fannie/modules/plugins2.0/DeliInventory/di.js on lines 253..260

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 114.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            } else {
                    var next = $(openInput).next('td.editable').get(0);
                    if (!next) {
                        var next = $(openInput).closest('tr').next('tr').find('td.editable').get(0);
                    }
            Severity: Major
            Found in fannie/modules/plugins2.0/DeliInventory/di.js and 1 other location - About 3 hrs to fix
            fannie/modules/plugins2.0/DeliInventory/di.js on lines 123..132

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (ev.shiftKey) {
                    var next = $(openInput).prev('td.editable').get(0);
                    if (!next) {
                        var next = $(openInput).closest('tr').prev('tr').find('td.cost').get(0);
                    }
            Severity: Major
            Found in fannie/modules/plugins2.0/DeliInventory/di.js and 1 other location - About 3 hrs to fix
            fannie/modules/plugins2.0/DeliInventory/di.js on lines 132..141

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status