Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/js/selectSubmit.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function selectSubmit has 110 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function selectSubmit(selector, myform, filter_selector, leave_submit, custom_callback) {

    var enterDown = 0;
    var enterUp = 0;
    var prevKey = 0;
Severity: Major
Found in pos/is4c-nf/js/selectSubmit.js - About 4 hrs to fix

    Function isFilterKey has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    function isFilterKey(keyCode)
{
    if (keyCode >= 65 && keyCode <= 90) {
        return true;
    } else if (keyCode >= 97 && keyCode <= 122) {
    Severity: Minor
    Found in pos/is4c-nf/js/selectSubmit.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function selectSubmit has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function selectSubmit(selector, myform, filter_selector, leave_submit, custom_callback) {
    Severity: Minor
    Found in pos/is4c-nf/js/selectSubmit.js - About 35 mins to fix

      Avoid too many return statements within this function.
      Open

              return true; // period
      Severity: Major
      Found in pos/is4c-nf/js/selectSubmit.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return true; // comma
        Severity: Major
        Found in pos/is4c-nf/js/selectSubmit.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return false;
          Severity: Major
          Found in pos/is4c-nf/js/selectSubmit.js - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status