Sign upLogin

CSNW/d3.compose

View on GitHub
Star
src/helpers/get-dimensions.js

Summary

Maintainability
A
2 hrs
Test Coverage

Consider simplifying this complex logical expression.
Open

  if (isSVG(selection)) {
    return {
      width: client.width != null ? client.width : attr.width || 0,
      height: client.height != null ? client.height : attr.height || 0
    };
Severity: Major
Found in src/helpers/get-dimensions.js - About 1 hr to fix

    Function getDimensions has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function getDimensions(selection) {
  // 1. Get width/height set via css (only valid for svg and some other elements)
  var client = clientDimensions(selection);

  if (client.width && client.height)
    Severity: Minor
    Found in src/helpers/get-dimensions.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function clientDimensions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function clientDimensions(selection) {
  var element = selection.node();
  var width = element && element.clientWidth;
  var height = element && element.clientHeight;
    Severity: Minor
    Found in src/helpers/get-dimensions.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status