CaffGeek/MBACNationals

Function ajaxSubmit has 150 lines of code (exceeds 25 allowed). Consider refactoring.

Open

$.fn.ajaxSubmit = function(options) {
    if (typeof options == 'function')
        options = { success: options };

    options = $.extend({

File jquery.form.dev.js has 325 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*
 * jQuery Form Plugin
 * version: 2.02 (12/16/2007)
 * @requires jQuery v1.1 or later
 *

Function fileUpload has 91 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function fileUpload() {
        var form = $form[0];
        var opts = $.extend({}, $.ajaxSettings, options);

        var id = 'jqFormIO' + $.fn.ajaxSubmit.counter++;

Consider simplifying this complex logical expression.

Open

    if (successful && (!n || el.disabled || t == 'reset' || t == 'button' ||
        (t == 'checkbox' || t == 'radio') && !el.checked ||
        (t == 'submit' || t == 'image') && el.form && el.form.clk != el ||
        tag == 'select' && el.selectedIndex == -1))
            return null;

Function cb has 41 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        function cb() {
            if (cbInvoked++) return;

            io.detachEvent ? io.detachEvent('onload', cb) : io.removeEventListener('load', cb, false);

Function formToArray has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

$.fn.formToArray = function(semantic) {
    var a = [];
    if (this.length == 0) return a;

    var form = this[0];

Avoid too many return statements within this function.

Open

    return el.value;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (v && v.constructor == Array) {
            for (var i=0,max=v.length; i < max; i++)
                a.push({name: n, value: v[i]});
        }
        else if (v !== null && typeof v != 'undefined')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (v && v.constructor == Array) {
            for(var j=0, jmax=v.length; j < jmax; j++)
                a.push({name: n, value: v[j]});
        }
        else if (v !== null && typeof v != 'undefined')

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if(!el.disabled && form.clk == el)
                a.push({name: n+'.x', value: form.clk_x}, {name: n+'.y', value: form.clk_y});

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if(n && !input.disabled && input.type == "image" && form.clk == input)
                a.push({name: n+'.x', value: form.clk_x}, {name: n+'.y', value: form.clk_y});

• Read up
  Read up