CaffGeek/MBACNationals

View on GitHub
Web.Admin/2015/js/galleria/plugins/picasa/galleria.picasa.js

Summary

Maintainability
F
1 wk
Test Coverage

Function load has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Galleria.prototype.load = function() {

    // pass if no data is provided or picasa option not found
    if ( arguments.length || typeof this._options.picasa !== 'string' ) {
        load.apply( this, Galleria.utils.array( arguments ) );
Severity: Major
Found in Web.Admin/2015/js/galleria/plugins/picasa/galleria.picasa.js - About 2 hrs to fix

    Function _call has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _call: function( type, url, params, callback ) {
    
            url = 'https://picasaweb.google.com/data/feed/api/' + url + '?';
    
            if (typeof params == 'function') {
    Severity: Minor
    Found in Web.Admin/2015/js/galleria/plugins/picasa/galleria.picasa.js - About 1 hr to fix

      Function _getSizes has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _getSizes: function() {
      
              var self = this,
                  norm = {
                      small: '72c',
      Severity: Minor
      Found in Web.Admin/2015/js/galleria/plugins/picasa/galleria.picasa.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        (function($) {
        
        /*global jQuery, Galleria, window */
        
        Galleria.requires(1.25, 'The Picasa Plugin requires Galleria version 1.2.5 or later.');
        Web.Admin/Content/galleria/plugins/picasa/galleria.picasa.js on lines 10..320

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 1719.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status