Sign upLogin

CaffGeek/MBACNationals

View on GitHub
Star
Web.Admin/AdminApp/Controllers/controller.contingent.js

Summary

Maintainability
C
1 day
Test Coverage

Function contingentController has 160 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    var contingentController = function ($scope, $http, $q, $location, modalFactory, dataService) {
        var url = $location.absUrl();
        var lastSlash = url.lastIndexOf('/');
        var province = url.slice(lastSlash + 1);
        var year = url.slice(lastSlash - 4, lastSlash);
Severity: Major
Found in Web.Admin/AdminApp/Controllers/controller.contingent.js - About 6 hrs to fix

    Function editDivisions has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            function editDivisions(teams) {
            var modalPromise = modalFactory.Divisions(teams);

            modalPromise.then(function (data) {
                //var currentTeams = $scope.model.Teams;
    Severity: Minor
    Found in Web.Admin/AdminApp/Controllers/controller.contingent.js - About 1 hr to fix

      Function editTeam has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              function editTeam(team) {
            var dfd = $q.defer();
            
            team.Bowlers = team.Bowlers || [];
      Severity: Minor
      Found in Web.Admin/AdminApp/Controllers/controller.contingent.js - About 1 hr to fix

        Function contingentController has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            var contingentController = function ($scope, $http, $q, $location, modalFactory, dataService) {
        Severity: Minor
        Found in Web.Admin/AdminApp/Controllers/controller.contingent.js - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  function loadHistory() {
            dataService.LoadContingentEvents(province).then(function (data) {
                $scope.model.Events = data.data;
            });
        };
          Severity: Minor
          Found in Web.Admin/AdminApp/Controllers/controller.contingent.js and 1 other location - About 40 mins to fix
          Web.Admin/AdminApp/Controllers/controller.participant.js on lines 27..31

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status